Separate module ("API") code from "E-mail" plugin code more cleanly

Created on 23 March 2018, over 6 years ago
Updated 26 February 2024, 9 months ago

Currently, we have two hook implementations (hook_mail() and hook_search_api_saved_search_presave()) in our module which exist not for the module itself, but just for the purpose of the "E-mail" notification plugin. (We have the same situation in the Search API regarding the "Content entity" datasource, actually.)

I think it would be cleaner to clearly separate them from the "normal" module code – either by having them in a separate include file (e.g., search_api_saved_searches.email_hooks.inc), or by moving just their function bodies to new static methods on the Email plugin class.

Input (or patches) welcome.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇹Austria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024