Support for additional tests

Re-rolled for 3.x. Seems to work for us; I think it's a good approach that the file system checks are optional, as at least we're mostly interested in cache and database availability and those can be sufficiently tested with this. The expandability is a big plus. Marking RTBC.

The last submitted patch, 6: 2950109-6-support_for_additional_tests.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Love this idea !
I'm looking for a simple health check module that offer an extension point (my usecase: Check if the non exposed search server is responding + cache service).

Here is an updated patch that just wraps each of the cache and file system tests in a try/catch. This makes it behave much more nicely if one of the tests actually fails. We've been using this in production on multiple sites for over 6 months.

The interdiff is ignoring whitespace.

The last submitted patch, 9: 2950109-9.support_for_additional_tests_with_try_catch.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

These patches have been failing testing, but not due to anything specific to the patches themselves. The issue seems to be with the tests for the module itself:

Warning: Your XML configuration validates against a deprecated schema.

This new patch addresses the code-standards messages also reported by testing:

health_check.module ✗ 6 more
line 14 Hook implementations should not duplicate @param documentation
14 Missing parameter type
39 Expected newline after closing brace
71 Inline @var declarations should use the /** */ delimiters
100 Expected newline after closing brace
102 The array declaration extends to column 111 (the limit is 80). The array content should be split up over multiple lines

src/Form/HealthCheckConfig.php ✗ 1 more
11 The class short comment should describe what the class does and not simply repeat the class name

If someone else could try out this latest patch with the try/catch added, it should be RTBC and a big improvement.

The last submitted patch, 11: 2950109-11.support_for_additional_tests_with_try_catch.patch, failed testing. View results →

D'oh! I misread the error in the test results the actual issue was that the patch in #5 that added the schema file had check_filesystem instead of check_filesystems. This latest patch fixes that.

Let's see if this passes now!

There was a general README.md change in 3.x so maybe you need to rebase etc.

Re-rolled patch for 3.1.