- π§π·Brazil rafmagsou
Resolve extra issues with most recent 4.x version
- π§π·Brazil rafmagsou
Fix, error when entity generation tries to get file entity
- π©πͺGermany gbyte Berlin
Please create a merge request so the review/merging process is smoother.
- π§π·Brazil rafmagsou
Sorry, I'll sooner, first I need to reach a fully version of patch 100% funcional and tested
Just adding a new verification. In case that the field "link_count" exists, the hook update 8305 will not be runned again, since this hook is beeing called on hook 8407 and in some cases this made the update fail.
Removed the truncate() from the code on #48, this way will not be necessary run the sitemap build after the hook execution
- last update
over 1 year ago 32 pass - last update
over 1 year ago 32 pass - πΊπΈUnited States emanaton
Reroll of the excellent work in #49 for the 4.1.7 branch:
- πΊπΈUnited States emanaton
Reroll of the excellent work in #49 for the 4.1.7 branch, this time without bugs!!!
- π§π¬Bulgaria vflirt
Thank you for working on this however it is not working.
In patch 40 there was added section to support "overrides_entity_type" to be array however in 43 and after that was removed. As a result of that removal the isOverwrittenForEntityType for file is always false because the check $plugin['settings']['overrides_entity_type'] === $entity_type_name will always fail. I will provide updated patch soon. - π§π·Brazil murilohp
The #51 works great but it has some unnecessary files like .idea/php.xml, .idea/workspace.xml, .idea/vcs.xml, this new patch removes them making it easier to review.
- πΊπΈUnited States emanaton
Ha! Sorry about that. Thanks for the cleanup of me file-piddle there, murilohp.
- πΊπΈUnited States mikepadiernos
The patch from #53 had a slight issue that ended up redeclaring
function simple_sitemap_update_8408()
so I ended up changing the second asfunction simple_sitemap_update_8409()
.
Other than that everything else remains the same to #53 - last update
7 months ago 32 pass - πΊπΈUnited States newme154
@mikepadiernos i'm still getting the 8408 issue here.
Could not apply patch! Skipping. The error was: The " https://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-supp... β " file could not be downloaded (HTTP/1.1 404 Not Found)
- πΊπΈUnited States emanaton
@newme154 - It appears that your error is due to an incorrect file name; you have
55
at the end instead of the53
that @mikepadiernos used. i.e. What you've pasted here show the file ashttps://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-support-for-version-4-2947456-55.patch
, but it should have beenhttps://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-support-for-version-4-2947456-53.patch
(the later being the link from comment #55). - πΊπΈUnited States mikepadiernos
@newme154 here's the proper path
https://www.drupal.org/files/issues/2024-04-16/simple-sitemap-files-support-for-version-4-2947456-55.patch
The date on your path was wrong and should be 2024-04-16 not 2024-04-01