Add Files Support

Resolve extra issues with most recent 4.x version

Fix, error when entity generation tries to get file entity

Please create a merge request so the review/merging process is smoother.

Sorry, I'll sooner, first I need to reach a fully version of patch 100% funcional and tested

Just adding a new verification. In case that the field "link_count" exists, the hook update 8305 will not be runned again, since this hook is beeing called on hook 8407 and in some cases this made the update fail.

Removed the truncate() from the code on #48, this way will not be necessary run the sitemap build after the hook execution

Reroll of the excellent work in #49 for the 4.1.7 branch:

Reroll of the excellent work in #49 for the 4.1.7 branch, this time without bugs!!!

Thank you for working on this however it is not working.
In patch 40 there was added section to support "overrides_entity_type" to be array however in 43 and after that was removed. As a result of that removal the isOverwrittenForEntityType for file is always false because the check $plugin['settings']['overrides_entity_type'] === $entity_type_name will always fail. I will provide updated patch soon.

The #51 works great but it has some unnecessary files like .idea/php.xml, .idea/workspace.xml, .idea/vcs.xml, this new patch removes them making it easier to review.

Ha! Sorry about that. Thanks for the cleanup of me file-piddle there, murilohp.

The patch from #53 had a slight issue that ended up redeclaring function simple_sitemap_update_8408() so I ended up changing the second as function simple_sitemap_update_8409().
Other than that everything else remains the same to #53

@mikepadiernos i'm still getting the 8408 issue here.

Could not apply patch! Skipping. The error was: The " https://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-supp... → " file could not be downloaded (HTTP/1.1 404 Not Found)

@newme154 - It appears that your error is due to an incorrect file name; you have 55 at the end instead of the53 that @mikepadiernos used. i.e. What you've pasted here show the file as https://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-support-for-version-4-2947456-55.patch, but it should have been https://www.drupal.org/files/issues/2024-04-01/simple-sitemap-files-support-for-version-4-2947456-53.patch (the later being the link from comment #55).

@newme154 here's the proper path https://www.drupal.org/files/issues/2024-04-16/simple-sitemap-files-support-for-version-4-2947456-55.patch
The date on your path was wrong and should be 2024-04-16 not 2024-04-01

Can this patch be re-rolled for >4.2.1?

Here is the re-roll, however I haven't had a chance to test it yet

Apologies! Use this file instead.

I get an error when I try to set a mimetype that has a '.' in it in config.

Drupal\Core\Config\ConfigValueException: application/vnd.ms-excel.addin.macroEnabled.12 key contains a dot which is not supported. in Drupal\Core\Config\ConfigBase->validateKeys() (line 209 of core/lib/Drupal/Core/Config/ConfigBase.php).

This appears to be happening in the filterFileMimeTypesOptions in the patch.

I don't know if this is the best approach, but could we change the '.' in the config key to something like a '_' instead so that the config can save?

  private function filterFileMimeTypesOptions(array $types_allowed = [], $by_extension = TRUE) {
    $all_file_types = $this->getAllFileMimeTypesOptions();
    $mimetypes_key = preg_replace('/\./', '_', $all_file_types['mimetypes']);

    if (empty($types_allowed)) {
      $options = ['' => $this->t('- All types -')];
      $options += array_combine($mimetypes_key, $all_file_types['mimetypes']);
      return $options;
    }

    if ($by_extension) {
      return $this->filterFileMimeTypesOptionsByExtension($all_file_types, $types_allowed);
    }

    return $this->filterFileMimeTypesOptionsByMimeType($all_file_types, $types_allowed);
  }

This is breaking with custom forms that extend EntityForm. I'm not sure where this should be addressed, but this breaks the loading of the access_scheme forms for workbench_access.

Specifically this line, https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/114/d...

I created the MR from the existing patch. I'm not sure I have time to dedicate to working on this issue. Does anyone have any suggestions for fixing this? I'm not sure just checking if the method getBundleEntityType exists is enough.

Just rebased the branch with 4.x and also made it compatible with Drupal 11, apparently the mime type changed the API and now the MR is compatible. The following patch was tested on version 4.2.2 and Drupal 11.2.

The patch available here https://www.drupal.org/files/issues/2024-04-16/simple-sitemap-files-supp... → is no longer compatible with Drupal core version 10.5.0 and Simple Sitemap module version 4.2.2.

I’ve made the necessary adjustments, and here is the updated patch that works with:

Drupal core 10.5.0
Simple Sitemap 4.2.2

https://www.drupal.org/files/issues/2025-06-26/simple-sitemap-files-supp... →

Just a note that the patch in #67, https://www.drupal.org/files/issues/2025-06-26/simple-sitemap-files-supp... → requires Drupal 11 and doesn't work with 10.5.

This patch has a fix from #66, it works with drupal 11 and simple_sitemap 4.2.2

The patch file in #66 and #70 includes this line:

$entity_settings = $entity_settings[$this->sitemap->id()];

within /src/Plugin/simple_sitemap/UrlGenerator/EntityUrlGenerator.php which seems entirely unnecessary and breaks the function.