- First commit to issue fork.
- 🇺🇸United States bradjones1 Digital Nomad Life
I ran into this today while doing some kernel testing. Basically, if you're installing content during a test and the SplStorage mapping of requests to stores is not cleared after a store is installed, you'll continue to get a resolved result of NULL. I think the reasonable thing to do here while maintaining BC is to add a typehint that says this could be NULL (a proper return value should be added in 3.x) as well as not statically-caching the miss.
- Merge request !241Don't statically cache current store if it's not resolved, and upate typehint → (Open) created by bradjones1
- last update
6 months ago 793 pass - Status changed to Needs review
6 months ago 1:35am 19 March 2024 - 🇺🇸United States bradjones1 Digital Nomad Life
Addressed the current store, at least. If maintainers are happy with this approach it's easy enough to extend to the other resolver.
- 🇮🇱Israel jsacksick
Change looks ok, perhaps we should return NULL if $request is NULL as it can be NULL. See the CurrentLocale service.
- Status changed to Needs work
6 months ago 7:46pm 19 March 2024