Entity metadata getter/setter ignores granularity

Created on 5 November 2017, about 7 years ago

Updated 18 December 2023, 11 months ago

Problem/Motivation

As a module user I want to have a consistent behaviour of date fields.

Steps to reproduce

Add a date field to some content type and limit its granularity to year, month, day
Set this field value via metadata wrapper with something like
```
$wrapped_node->{$field_name}->value = $timestamp;
```
Fetch value from the field

Expected behaviour: fetched value limited to specified granularity.
Current behaviour: fetched value is the same as was set, not changed in any way

Proposed resolution

Apply field granularity to the date in both date_entity_metadata_struct_getter() and date_entity_metadata_struct_setter().

Remaining tasks

Write test - Done
Write patch - Done
Review
Test
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇳🇿New Zealand RoSk0 Wellington

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Core: 7.x + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
83 pass, 2 fail
Comment 11 months ago →
🇳🇿New Zealand RoSk0 Wellington
Re-roll of #10.

Test migrated from the new file into existing.

Also, we are using patch from #6 in production on a date heavy project since 2018.
Comment 11 months ago →
System Message
The last submitted patch, 21: date-2921146-21.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024