- First commit to issue fork.
- Merge request !78Issue #2895873: UUID is regenerated every time a pattern is saved → (Open) created by codebymikey
- Assigned to codebymikey
- Status changed to Needs review
10 months ago 12:23pm 19 June 2024 Added change to
\Drupal\pathauto\Entity\PathautoPattern::addSelectionCondition()
which persists the UUID if the configuration includes auuid
property saving the need to regenerate a unique UUID everytime.- Status changed to Needs work
9 months ago 9:23am 1 August 2024 - 🇨🇭Switzerland berdir Switzerland
This looks good at first glance, but it's a non-trivial amount of code to the form handling, would be great to make sure we have tests covering this. There is \Drupal\Tests\pathauto\FunctionalJavascript\PathautoUiTest::testPatternsWorkflow, where we add, edit and delete patterns, but we have little coverage for the conditions, specifically nothing about removing them.
So, would be good to extend that by removing the bundle condition and then also once save a pattern and ensure nothing on the config entity changes (load config entity, toArray(), save in UI without changes, then load again and compare)