Source_url is wrongly used in aggregator_feed_source preprocess function

Created on 31 May 2017, about 7 years ago
Updated 7 June 2024, 20 days ago

Hi all,
I've noticed a functional bug in aggregator module where on the aggregator-feed-source.tpl $source_url gets printed but in its preprocess function the variable comes from $feed->link, not the ->url where it should.
I'm not fully sure is it the only place where aggregator prints wrong value out, but for sure it is.
Test case:
Enable aggregator module.
Create a new feed under admin/config/services/aggregator/add/feed and add a valid rss url to its URL field.
Save the feed and visit its source page, clicking on the name of the created feed on admin/config/services/aggregator page.
You'll see your site's URL instead of the previously set url on the feed's page (if this feed is the first and only created one on your site, it should be available under aggregator/sources/1)
Semantically this URL should show the url of the feed, not the site's one or any others, also when you go to configure the feed (aggregator/sources/1/configure) you see the URL of the feed in the textfield of URL.
Patch is coming.

πŸ› Bug report
Status

Needs work

Version

7.0 ⚰️

Component

aggregator.module

Created by

πŸ‡­πŸ‡ΊHungary tatarbj Brussels

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΈπŸ‡°Slovakia poker10

    Thanks for working on this. I have verified this is still an issue. I think we need to add a simple test here, but otherwise the fix looks good.

Production build 0.69.0 2024