helper function _imagemagick_check_path() has wrong if()???

Created on 15 April 2017, about 8 years ago
Updated 20 January 2025, 5 months ago

I study your code atm.
I saw in _imagemagick_check_path() the following sequence:

  // If only the name of the executable is given, we only check whether it is in
  // the path and can be invoked.
  if ($file != 'convert' && $file != 'gm') {
...
}

In my opinion that means that the string doesn't have to be 'convert' as well as 'gm'.
To produce this in code in my mind there should be a "||" instead "&&", isn't it?

Best wishes

maen

🐛 Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇩🇪Germany maen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024