- last update
8 months ago 19 pass, 2 fail - 🇺🇸United States kkohlbrenner Saint Louis, MO
We are currently running the 4.x version of SimpleSAMLphp_auth module because we are on Drupal 10 and the 4.x version currently only supports D10.
Despite 8.x-3.x-dev being targeted, patches #15 and #16 apply successfully the 4.x branch. Like @dgaspara, we need to support multiple auth sources / service providers so #16 provided functionality we wanted. However, after applying the patch in #16, we ran into issues, so I rerolled the patch and also included an interdiff.
I took a slightly different approach from #16 regarding implementation, so open to feedback!
I'm also updating the target branch :)
The last submitted patch, 18: simplesamlphp_auth-2869107-18.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- 🇺🇸United States kkohlbrenner Saint Louis, MO
Updating the patch, including an interdiff between previous patch. In the previous patch, SimplesamlphpAuthManager::externalAuthenticate() was not updated to account for the dynamic $sp when multiple authsources are configured. This new patch solves for this and externalAuthenticate(), when called in the Controller with a dynamic $sp value, will send the argument to the externalAuthenticate() method which executes ::getSimpleSamlInstance() with the $sp argument.
Notably, the patch does not include tests, because, well, time constraints.
- 🇨🇳China fishfree
@kkohlbrenner After patching, I still found nowhere to configure multiple authsources in Drupal.