Provide different versions of ModuleHandler::invokeAll() for performance

public function invokeAllReturnNothing($hook, array $args) { foreach ($this->moduleHandler->getImplementations($hook) as $module) { $function = $module . '_' . $hook; call_user_func_array($function, $args); } } public function invokeAllReturnArraySum($hook, array $args = array()) { $return = array(); foreach ($this->getImplementations($hook) as $module) { $function = $module . '_' . $hook; $module_result = call_user_func_array($function, $args); if (NULL !== $module_result && is_array($module_result)) { $return = $module_result + $return; } } return $return; }

public function invokeAllReturnKeyed($hook, array $args = array()) { $return = array(); foreach ($this->getImplementations($hook) as $module) { $function = $module . '_' . $hook; $return[$module] = call_user_func_array($function, $args); } return $return; }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 3 months ago →
🇺🇸United States nicxvan
Do you have examples of the types of hooks for each?
Comment 3 months ago →
🇺🇸United States nicxvan
Comment 3 months ago →
🇩🇪Germany donquixote
Looking at ->invokeAll() calls, here are some examples for the most common types.

No return value:
hook_cache_flush()
hook_rebuild()
hook_(entity|ENTITY_TYPE)_(presave|insert|update|predelete|delete|revision_create)()
hook_entity_bundle_create()
hook_entity_bundle_delete()

Merge:
hook_updater_info()
hook_filetransfer_info()
hook_requirements()
hook_update_requirements()
hook_entity_preload()
hook_(entity|ENTITY_TYPE)_(access|create_access)()
hook_field_info_max_weight()
hook_entity_extra_field_info()
hook_entity_operation()

We could investigate if these all need the same merge logic.
I am looking at ->invokeAllWith() calls now..
Comment 3 months ago →
🇩🇪Germany donquixote
The most obvious first step here would be a dedicated logic for hooks with no return value and regular passing of parameters, so the first group in my previous comment.
I am not sure how much improvement this would bring, seems like a micro optimization.
If we only measure the raw overhead from the module handler, it will make a difference. If we measure total request time it will be overshadowed by other things.
Comment 3 months ago →
🇩🇪Germany donquixote
And yes this part still applies with the new event hook system.
Comment 3 months ago →
🇩🇪Germany donquixote
Actually, if we inline most of the stuff in invokeAll() we probably get some improvement.
We can do this in the other issue 📌 Optimize ModuleHandler::invokeAll() Active .
Perhaps the remaining benefit from separate methods per return value behavior would have diminishing returns after that other optimization.