Use form attached for javascript settings

Created on 6 December 2016, about 8 years ago

Updated 11 October 2024, 4 months ago

After updating to the last hide_submit version last week we're experiencing javascript errors on some pages. This is because hook_form_alter is only fired on non-cached forms. I'm not sure if this is a quirk of our site or a drupal thing, but I created a patch which replaces drupal_add_js with $form{'#attached'] that fixes the problem for us.

🐛 Bug report

Status

RTBC

Version

2.0

Component

Code

Created by

🇳🇱Netherlands SpaghettiBolognese

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
I think I prefer this over drupal_add_js because at least then it can be altered from an overriding form_alter. Patch applies cleanly, not seeing any issues with the patch applied on admin forms, or webforms.
Comment 4 months ago →
🇬🇧United Kingdom aaron.ferris
Thanks for working on this.
Comment 4 months ago →
System Message

0fd09adf committed on 7.x-2.x
Issue #2833453: use form attached
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024