- π©π°Denmark Birk
I've just tested the #29 patch on version 2, it applied and worked as expected.
- First commit to issue fork.
- last update
about 1 year ago 124 pass, 2 fail The patch from #29 didn't apply any more on the latest version, so I created an issue fork and PR that fixes that.
- First commit to issue fork.
- last update
about 1 year ago 125 pass, 2 fail - last update
about 1 year ago 125 pass, 2 fail - last update
about 1 year ago 125 pass, 2 fail - First commit to issue fork.
- First commit to issue fork.
- πΊπΈUnited States adamzimmermann
I'm not sure what is going on with the
preview-image-styles
fork, but the patch from that MR would not cleanly apply. I suspect it has something to do with the fork being out of sync. I tried to update the fork, but there was a conflict.I didn't have the time to fully sort this all out, so I just recreated the patch for the
2.x
branch.I tried to create a new MR instead of a patch (hence the new extra branch), but again I was having issues with the fork being out of date and the
2.x
branch in the fork was not up to date enough to create a patch against.Hopefully this patch helps someone who can sort this out, or just apply the patch directly like the old days.
Unfortunately the patch also includes a fix from another issue, as trying to apply both patches at the same time was causing a patch application failure. However, both patches were needed, as the other patch allows the preview controller to not throw an error ( π Preview results in Error: Call to a member function getDefinitions() on null Active ).
Once that issue is merged, the patch will need to be re-rolled. Until then, I can confirm that this patch works on
2.x
.Perhaps the "Version" on this issue should be updated to
2.x-dev
as well? I'll let the powers to be handle that though. - πΊπΈUnited States adamzimmermann
The issue referenced in the previous comment was merged. Re-rolled the patch so it applies to 2.1.2