Group content label for group membership not updated when original entity label changes

Created on 15 July 2016, almost 8 years ago
Updated 12 June 2023, about 1 year ago

Problem/Motivation

When a group content item of type group_membership is created, it's assigned a label based on the label of the corresponding user entity. However, when the original user entity label value is changed, the group content label is not updated.

Steps to reproduce:

  • Create a group Group A. Create a user, Tester. Assign Tester as a member of Group A.
  • Edit Tester's user account, changing name to Testy.
  • View Group A and click the "Members" tab. Result: group member's name is correctly listed as Testy.
  • Click link for Testy. Result: title of page is "Tester" (the obsolete user name).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada nedjo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • πŸ‡ͺπŸ‡ΈSpain unstatu

    @lind101 thanks for your comments. As you mentioned, the group_content label depends on the GroupContentEnabler that manages it.

    I have slightly modified the MR code (https://git.drupalcode.org/project/group/-/merge_requests/34/diffs?commi...) so we check that the GroupContentEnabler generated label does not match with the group_content stored label before saving the entity. This mitigates the performance problem when the user did not change the target entity label.

    Although we still having a problem if the target entity changes the label and has many group_content entity associated with it. It can take a lot of time to save all the related group_content entities. However, I don't think this is something that can be solved. If you have any idea regarding this, I'll be happy to implement it.

Production build 0.69.0 2024