- First commit to issue fork.
- π§πͺBelgium StryKaizer Belgium
Pushed branch fixes this issue by not altering (nor wrapping) urls with data-embed-url.
This allows to use core "Convert URLs into links" filter triggering after this filter without issues. - Merge request !25Only add data-embed-url properties when the url is actually a data embed β (Merged) created by StryKaizer
-
mark_fullmer β
committed eebc4329 on 3.x authored by
strykaizer β
Issue #2761187 by strykaizer, navneet0693, loze, mark_fullmer,...
-
mark_fullmer β
committed eebc4329 on 3.x authored by
strykaizer β
- πΊπΈUnited States mark_fullmer Tucson
The code change in the MR makes perfect sense, and I think it also reflects how the code should have been implemented in the first place, rather than an affordance for an edge case. In that sense, I agree with the comment in #8, arguing for this in favor of #2864302: Add validation to ensure URL is embeddable β . Merging. Thanks, everyone!