BigPipe causes PHP notices with JavaScript disabled on error pages

Created on 2 March 2016, almost 9 years ago
Updated 29 February 2024, 10 months ago

Problem/Motivation

Under some circumstances, BigPipe throws PHP notices because it tries to explode on <drupal-big-pipe-scripts-bottom-marker> in \Drupal\big_pipe\Render\BigPipe::sendPreBody(), while that marker is missing.

This seems to happen when subrequests are created via DefaultExceptionHtmlSubscriber with javascript disabled.

Notices:

Notice: Undefined offset: 1 in Drupal\big_pipe\Render\BigPipe->sendPreBody() (line 143 of core/modules/big_pipe/src/Render/BigPipe.php).
Notice: Undefined offset: 2 in Drupal\big_pipe\Render\BigPipe->sendPreBody() (line 143 of d8/core/modules/big_pipe/src/Render/BigPipe.php).

Steps to reproduce:

On a fresh D8.1.x, create some content, disable javascript in your browser, visit /page-does-not-exist: this should trigger the above notices in the log.

🐛 Bug report
Status

Fixed

Version

9.2

Component
BigPipe 

Last updated 3 days ago

Created by

🇧🇪Belgium mr.baileys 🇧🇪 (Ghent)

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇷🇺Russia vvs Russia

    Fix patch from #22 to drupal 9.5

  • 🇷🇺Russia vvs Russia

    upd

  • 🇨🇦Canada mebel192

    Original Text : Après avoir cherché en profondeur la cause possible de l’erreur, il se peut que certaines extensions de navigateur qui injectent du code dans l’en-tête de la page provoquent une erreur avec BigPipe. Essayez de désactiver certaines extensions de votre navigateur pour identifier laquelle pose problème.

    After thoroughly investigating the possible cause of the error, it may be that some browser extensions that inject code into the page head tag are causing an error with BigPipe. Try disabling certain extensions in your browser to identify which one is causing the problem.

Production build 0.71.5 2024