- First commit to issue fork.
- 🇺🇸United States dcam
I converted the patch in #2 to an MR and added the schema verification tests. Some of the original changes are irrelevant now because this issue is so old. But the CKEditor plugin schema is of particular note. I noticed there's no fallback for
ckeditor5.plugin.*, but when I attempted to add one other tests started failing with the following message:Failed asserting that exception of type "TypeError" matches expected exception "Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException". Message was: "Cannot assign Drupal\Core\Config\Schema\Ignore to property Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition::$schema of type Drupal\Core\TypedData\TraversableTypedDataInterface"
So there's an check for a specific data type here. I'm not sure if this invalidates the need for a fallback schema or not. I ended up removing that change from the MR.
Also, I don't know if there are other new plugin types in Core that need this treatment. If anyone knows of some, then let me know.