Rework EntityInlineEntityFormHandler::tableFields()

Created on 9 November 2015, over 9 years ago
Updated 8 January 2025, about 2 months ago

The current code has two problems:
1) The column label logic was never ported, so the label/bundle columns are always called "Label" and "Type"
2) The label field doesn't invoke $entity->label(), therefore showing the wrong label when the entity has a label callback or any custom logic on the class itself.
3) The whole fallback to id only made sense in D7 cause many entity types didn't have labels in the beginning. In D8 all entity types have labels.

Solution:
Kill the id fallback, port the column label logic, introduce a special IEF field type that calls $entity->label().

Patch incoming.

πŸ“Œ Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡·πŸ‡ΈSerbia bojanz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States dcam

    Since Drupal 7 is now end-of-life I am closing some old issues for the 7.x branch of this module. If this issue is still relevant for the 3.x branch of the module, then feel free to reopen it.

Production build 0.71.5 2024