The documentation of hook_update_N() says:
The system will stop iterating this update when $sandbox['#finished'] is left unset or set to a number higher than 1.
This is only kind of true because
// Record the schema update if it was completed successfully.
if ($context['finished'] == 1 && empty($ret['#abort'])) {
drupal_set_installed_schema_version($module, $number);
}
which means if $sandbox['#finished'] is > 1 then the schema_version for the module won't be updated (even if the updates run successfully).
Since
I think hook_update_N() should not differentiate between 1 and >1 'finished' values either.
Review patch.
Needs work
7.0 ⚰️
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Thanks for working on this.
The patch #1 needs work. We should remove this change, as it was never committed to D8+ and D10 code still has the original code:
- if ($context['finished'] == 1 && empty($ret['#abort'])) {
+ if ($context['finished'] >= 1 && empty($ret['#abort'])) {
And then we need to compare and verify, if the comment changes are correct per #2521776: Update documentation for hook_update_N() for Drupal 8 → (just for the relevant parts). Thanks!