template_preprocess_node() does not add cacheability metadata

This came up in BSI triage today. The code still exists in template_preprocess_node as per the IS but it's not clear to me if the solution in #10 is the way forward?

It would be good to get an updated IS with a bit more detail and then we'll need a reroll on an MR. I'm guessing based on #43 we'll need to handle deprecating the page variable too.

This has some crossover with other issues now.

🐛 Any page with a node on it is completely uncacheable if you do not have the "access user profiles" permission Active is similar but with different bugs.

📌 Deprecate $variables['page'] for node.html.twig Needs review is deprecating $variables['page']

✨ [META] Expose Title and other base fields in Manage Display Active for making the title configurable in manage fields.

Thanks @catch! It seems like this is a duplicate of 📌 Deprecate $variables['page'] for node.html.twig Needs review then? Although the title here is more generic, it's just dealing with the page variable.

I think $variables['author_picture'] is also missing cacheability metadata - it should be adding the tags for the node author probably unless those are implicitly merged somehow.

But otherwise it looks like I opened a duplicate of my own issue yeah, wouldn't be the first time sadly.