redirect_element_validate_redirect contains code that seemingly does nothing

Created on 5 May 2015, about 9 years ago
Updated 24 June 2024, 4 days ago

In redirect.admin.inc, the redirect_element_validate_redirect function contains code that seemingly does nothing.

It sets $value twice, to two different items, without using the variable in between the two definitions.

It checks to see if $value is not equal to '<front>', but earlier it passes the value through drupal_get_normal_path(), which modifies '<front>' to an empty string.

This was discovered when I was trying to exempt <front> from validation in my patch for #2327247: Validate internal URLs so redirects cannot lead to 404 pages β†’ .

πŸ› Bug report
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada kpaxman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States wylbur Minneapolis, Minnesota, USA

    Since the module is working, and this report does not indicate otherwise, I am marking this as closed - won't fix. Please reopen if there is an issue with the operations of the module.

    Patches are also welcome.

Production build 0.69.0 2024