Every role is trusted

Created on 5 May 2015, about 10 years ago
Updated 18 January 2023, over 2 years ago

Problem/Motivation

The function security_review_trusted_roles() returns every role as trusted.

Proposed resolution

The problem comes from using the values (role names) of the security_review_untrusted_roles() function's return value instead of the keys (role IDs) in the SQL query.
Applying array_keys() on the $untrusted_roles array solves the problem.

Remaining tasks

Review, commit.

User interface changes

None.

API changes

None.

🐛 Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇭🇺Hungary banviktor

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024