\Drupal\Core\Updater\Updater::makeBackup should probably be removed, and the code path that calls it is broken

Created on 20 April 2015, about 10 years ago

Updated 30 January 2023, over 2 years ago

Problem/Motivation

Currently the code looks like this

/**
   * Performs a backup.
   *
   * @param \Drupal\Core\FileTransfer\FileTransfer $filetransfer
   *   Object which is a child of FileTransfer.
   * @param string $from
   *   The file path to copy from.
   * @param string $to
   *   The file path to copy to.
   *
   * @todo Not implemented.
   */
  public function makeBackup(FileTransfer $filetransfer, $from, $to) {
  }

Added in #538660: Move update manager upgrade process into new authorize.php file (and make it actually work) → .

Proposed resolution

Remove the method and associated code

No tests are breaking, yet this method is called, meaning, we need to write tests and also actually implement this.

Remaining tasks

Decide on removal or implementation

User interface changes

API changes

🐛 Bug report

Status

Needs work

Version

9.5

Component

Update →

Last updated 3 days ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dww

Created by

🇩🇰Denmark googletorp

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Closed: won't fix 19 days ago3:02am 14 May 2025
Comment 19 days ago →
🇺🇸United States dww
Now that 📌 Deprecate/remove the ability to update a module from a URL and authorize.php Active and child issues are done, all this code is deprecated and will be removed in D12.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024