Contrib.social

EditorImageDialog passes incorrect arguments to file_validate_image_resolution

Open on Drupal.org →
Created on 4 December 2014, almost 10 years ago
Updated 8 March 2024, 6 months ago

Problem/Motivation

file_validate_image_resolution() expects a resolution like 600x400 but EditorImageDialog::buildForm() passes 600×400. Yep x is not ×.

Steps to reproduce

Proposed resolution

Remaining tasks

Postponed on 📌 Write integration test for EditorImageDialog Closed: outdated
Change back to using ×.
Write a test so this does not revert again.

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Closed: outdated

Version

11.0 🔥

Component
Editor  →

Last updated 1 day ago

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024