- 🇺🇸United States TomTech
Automatically closed because Drupal 7 security and bugfix support has ended → as of 5 January 2025. If the issue verifiably applies → to later versions, please reopen with details and update the version.
I have the following setting in my Paypal EC payment method:
Setting #1: Ask for a shipping address at PayPal if the order does not have one yet.
Setting #2: Update shipping customer profiles with address information the customer enters at PayPal.
I added some alterations so that the user won't be asked for any information related to shipping when they did not purchase anything that should be shipped [e.g., digital mp3s]
Since, I didn't ask for any shipping information even when going through Paypal (simply altered NOSHIPPING through hook_commerce_paypal_api_request_alter()), Paypal will not return any shipping info when Paypal EC performs GetExpressCheckoutDetails. Since Setting #2 is enabled, Paypal EC will create a profile anyway with empty values.
I suggest to not create a profile at all when Paypal doesn't return the address to prevent empty shipping informations to be created. Patch is attached.
I simply moved some code to create the address first, and if the address are just empty values, do not proceed with overwriting / creating the profile. I just moved the chunk where the new address is being built at the beginning and added an "override_address" flag.
Closed: outdated
2.0
PayPal EC
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Automatically closed because Drupal 7 security and bugfix support has ended → as of 5 January 2025. If the issue verifiably applies → to later versions, please reopen with details and update the version.