hook_modules_preinstall() is invoked more than it needs to be

Created on 5 August 2013, about 11 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

The documentation for hook_modules_preinstall() implies that it should be called once per install cycle, but the way it is actually invoked, it gets invoked once per module being installed, with an array of only one module (the one being installed at the time).

This isn't necessarily wrong, it just doesn't need to happen so many times.

Proposed resolution

Move the hook invocation from within the install loop to outside.

Remaining tasks

TBD

User interface changes

N/A

API changes

N/A

Related Issues

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
InstallΒ  β†’

Last updated 2 days ago

No maintainer
Created by

πŸ‡ΈπŸ‡ͺSweden iamEAP

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024