- last update
7 months ago 2,176 pass - Merge request !8243Issue #1982810 by poker10: Core entity_get_controller gets a NULL controller class β (Open) created by poker10
- last update
7 months ago 2,180 pass - πΈπ°Slovakia poker10
I have drafted a CR here: https://www.drupal.org/node/3451532 β
Also moved the patch to the MR so that we are sure it is still green: https://git.drupalcode.org/project/drupal/-/pipelines/187106
Adding a tag for the final review.
-
mcdruid β
committed 842b56b4 on 7.x
Issue #1982810 by poker10, mcdruid, Liam Morland, jp.stacey, joseph....
-
mcdruid β
committed 842b56b4 on 7.x
- Status changed to Fixed
7 months ago 12:22pm 3 June 2024 - π¬π§United Kingdom mcdruid π¬π§πͺπΊ
I thought this one seemed familiar when I started reading :) I suppose both @poker10 and I have written parts of the patch (/MR) so perhaps neither of us should commit it.
However, I think this is okay to commit on the basis that the change is to more cleanly handle the situation where Drupal is going to fail to load a valid controller class anyway. We have tests (thank you!) to prove that the code does what we expect, and multiple reports that (earlier versions) of this change solved (/ mitigated) the originally reported problem.
Also, it's sufficiently long ago that I hardly remember writing the code so it's like reviewing someone else's patch anyway :)
Anyone with a site that hits this error still has some debugging to do to, but it's an improvement on hitting unhandled Fatal errors.
Automatically closed - issue fixed for 2 weeks with no activity.