[meta] Mark 'half-converted' classes somehow

Created on 1 April 2013, about 12 years ago
Updated 5 February 2025, 2 months ago

While some of the code is converted to modern subsystems for real (ie. injection, plugins etc) some are converted to classes only because of routes and are a nonchanged move into a class from module code. I see a lot of ConfirmFormBase conversion doing this. This definitely will make people uncertain in best practices and we should document them as not following best practices.

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component

other

Created by

πŸ‡¨πŸ‡¦Canada chx

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand luke.stewart

    Is this still the case?

    Suspect there has been some work in this space over the last few years. Can this be closed now?

    Otherwise sounds like the next steps here are to identify the relevant classes and add an appropriate comment.

  • πŸ‡¨πŸ‡¦Canada Charlie ChX Negyesi 🍁Canada

    It's more relevant than ever because core just moved old procedural code into Hooks classes.

    Almost all of Views code is unchanged since 7.x-3.x or even older.

    And so on.

Production build 0.71.5 2024