Remove separate CSS_AGGREGATE_THEME aggregate file

Created on 22 February 2013, almost 12 years ago
Updated 16 April 2024, 8 months ago

Problem/Motivation

We currently have a slightly-awkward CSS aggregation strategy. Our theme-level CSS is artificially forced to be loaded after all module-level CSS. That means we have twice as many aggregated CSS files as are necessary.

Proposed resolution

First we need to refactor all of core's CSS to be component-based. See #1921610: [Meta] Architect our CSS β†’ Drupal core's current CSS has many issues that require our current module/theme separation.

After we refactor our module CSS to be discrete design components with low selector specificity, we can freely group module and theme CSS without worry of needing specific ordering within the aggregate file. And then we can remove CSS_AGGREGATE_THEME aggregate file and replace it with a 'weight' inside the existing CSS_AGGREGATE_DEFAULT file.

Remaining tasks

none

User interface changes

none

API changes

Removes the CSS_AGGREGATE_THEME constant.

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
CSSΒ  β†’

Last updated 5 days ago

Created by

πŸ‡ΉπŸ‡ΌTaiwan johnalbin Taipei, Taiwan

Live updates comments and jobs are added and updated live.
  • mobile

    Issue related to Drupal on mobile devices.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¬πŸ‡§United Kingdom catch

    The pre-requisite to this would be πŸ“Œ Refactor system/base library Needs work and remaining bits of #1921610: [Meta] Architect our CSS β†’ (and any similar issues) - currently we are still loading a lot of module CSS on every page, that is only for specific core components.

    Now that we can assert aggregate counts and sizes across pages in tests, it would be easy to try a patch here and see how it affects the existing (or newly added for this issue) test coverage.

Production build 0.71.5 2024