- 🇺🇸United States wolcen
Patch #14 still works (Thank you - this has been surprisingly disruptive to my workflow).
There seems not to be a shortage of people already using what they see as a well-defined shortcut....is there a specific complaint about the UI as that patch adds it? Perhaps some direction we hoping for instead? Do we need a key-capture? Or maybe a simpler "select modifier1+modifier2[optional]+character entry form for one/two shortcuts?
FWIW:
- alt+shift+d => firefox(linux) bound to "Tabs sharing devices"; and does nothing even when menu not displayed (i.e. not presently sharing anything).
- alt+shift+g => firefox(linux) works
Should it provide some further insight: like many of us, I often have many more tabs open than I "should". As such, my default navigation (aside from pinned things) is often to alt+d and enter %my-tab-to-jump-to in order to get where I need to be next. This default key binding leaves me struggling every time I don't get there (and ctrl+L is nowhere near as easy to type, at least for me on standard qwerty - I have tried to switch to it). I understand this may feel like a minor annoyance, but for something used so heavily, and with a module so many people still enjoy, it's a real bummer for some of us, so I'd love to help push this over the finish line.
- 🇺🇸United States mlncn Minneapolis, MN, USA
Back to needs review at the very least, for the patch in #14 as per #20
It was RTBCd (comments #15 and perhaps #18) and it still works 7 years later! To address #16 the module could offer an interface for capturing keycodes but clearly that is not needed to address the immediate pain of Coffee stealing a common browser shortcut. And there is no need to prompt administrators to configure the keys because there is an update hook to assign all the currently available keys by default.
Improvements that could be made in follow-ups but should be considered out of scope for this patch which allows site administrators to making Coffee more compatible with browsers and more usable for more people:
- Allowing any key code to be used.
- Providing a helper for capturing keycodes.
- Allowing individual users to set their own keycodes.
Changing the issue title to make clearer that last one in particular was never the intent of any of the patches contributed here.