Replace aggregator category system with taxonomy

Created on 7 January 2005, almost 20 years ago
Updated 27 June 2023, over 1 year ago

Updated: Comment #82

Problem/Motivation

Aggregator categories are one of the last core sub-systems that do not use the entity API.
Instead it relies on its own API. While we tried making its storage swappable with a seperate service, categories are still un-translatable and we are still re-inventing the wheel.

Proposed resolution

Categories should be Terms instead.
Get rid of the custom code and the raw-sql queries. Use the entity API instead.
Get rid of the custom tables that handle the relations between categories and feeds/feed items and instead use Field API ; Attach an entity reference field on feeds and feed items entities instead.
We will also need an aggregator specific vocabulary to put existing categories from sites upgrading from D7.

Remaining tasks

A maintainer is needed to approve this API change for D8
Reroll patch in #72 and see wherre we stand with tests after #2004316: Exception on field_purge_batch() after deleting a field β†’ was fixed.
Fix any potential newly introduced failures.
Review and RTBC

User interface changes

All the category crud forms will use the term forms instead provided by the taxonomy module, which means taxonomy will be a dependency

Aggregator will get its own field-ui for managing feed entities under the current administration page

API changes

aggregator_category, aggregator_category_feed and aggregator_category_item tables are being removed in favor of taxonomy tables and tables created by Field API
aggregator_category_selector is removed from aggregator's config and moves to the field instance settings instead
aggregator_save_category is removed in favor of just $category->save()
aggregator_category_load is removed in favor of entity_load

Original report by qgil

The Aggregator module allows the creation of categories to file the news feed. The creation of categories is done manually, though.

What about the possibility to assign an already created vocabulary to define the aggrgator categories?

It would be quite useful. For example, if my site has a vocabulary "topic" with entries such as film, radio, tv, press with which I organize articles and the forum, I could use this same vocabulary to organize news feeds.

πŸ“Œ Task
Status

Closed: outdated

Version

2.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain qgil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States dcam

    I'm closing this as being outdated. In the 9.5 years since the categories were removed no one has requested that they be restored, complained about not being able to bring them over from an older D7 site (at least not in this issue), or bothered to try and reroll the old patch. Because categories were removed "rerolling" isn't even an accurate term for what would have to happen. Practically speaking, re-adding categories would be a feature request because it means asking the maintainers and community to create and support something that currently isn't a feature. So in the absence of significant feedback from users requesting the return of categories I'm not inclined to work on this.

    If anyone does want them, then I'd prefer for a new issue to be created as a feature request, including an upgrade path from older versions of Drupal. This one is too long and probably contains too much irrelevant content for future work.

Production build 0.71.5 2024