Array flip error when a taxonomy term field has a NULL value

Open on Drupal.org →

Created on 6 March 2012, over 12 years ago

Updated 26 May 2023, about 1 year ago

Problem/Motivation

If a field associated with an entity points to a taxonomy term, and there happens to be no data in that field on that entity (i.e., the term tid is NULL), then taxonomy_field_formatter_prepare_view() attempts to load taxonomy term data for a NULL tid. In doing so, DrupalDefaultEntityController::load() attempts to array flip a NULL value, which is not allowed (only strings/ints are allowed), resulting in the following PHP warning and associated log message:

Warning: array_flip() [function.array-flip]: Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 177 of /path/to/drupal/includes/entity.inc).

Proposed resolution

The proposed resolution is a simple patch that performs a check for is_numeric() on the tid in taxonomy_field_formatter_prepare_view() before adding it to the list of tids to be loaded. The rationale here is that taxonomy_term_load() does the same check before calling taxonomy_term_load_multiple(), so we should be performing the same check in taxonomy_field_formatter_prepare_view().

Remaining tasks

The proposed patch should get at least a couple of non-bot reviews before committing. It's relatively small though, and passes tests.
Afterward, the patch will need to be applied to Drupal 7 as well.

User interface changes

None.

API changes

None.

Original report by POVYLAZZZ

I was working on my site then on node creation pages I started seeing this error:
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/p/includes/entity.inc).
What could have caused it?
I read that FileField Sources and Page titles could be the reason of this error but I have never used the first and have not yet installed Page titles.
What type of module could be to blame?

🐛 Bug report

Status

Fixed

Version

7.0 ⚰️

Component

Last updated 2 days ago

Maintained by
🇺🇸United States @xjm
🇬🇧United Kingdom @catch

Created by

🇱🇹Lithuania POVYLAZZZ

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & SQLite 3.27
last update about 1 year ago
2,145 pass
Comment about 1 year ago →
🇸🇰Slovakia poker10
We have used similar fix in this issue: #3006007: Don't try to load the user picture if it's not set → . Adding a tag for the other maintainer review.
Status changed to RTBC about 1 year ago1:10pm 24 May 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Patch Failed to Apply
Comment about 1 year ago →
🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
I could go either way with whether we avoid putting the entries into the $tids array in the preceding loop, or filter them out when passing the list to taxonomy_term_load_multiple() per the last patch.

I don't think there's much difference, but this approach is simple.

I can't see how it would cause problems as presumably taxonomy_term_load_multiple() was never going to return anything for the null elements.

Thanks for adding tests!

I think this looks good and is ready to commit.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
Patch Failed to Apply

Comment about 1 year ago →

poker10 → committed f1199f88 on 7.x

Issue #1470236 by iamEAP, mstrelan, poker10, divesh.kumar: Array flip...

Status changed to Fixed about 1 year ago4:56pm 26 May 2023
Comment about 1 year ago →
🇸🇰Slovakia poker10
Committed, thanks everyone!
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024