Will need an upgrade hook + test coverage.
smustgrave → created an issue.
Actually another question do we want to change the storage body file to be text formatted not text formatted with summary since the goal is to deprecate that plugin?
Going to give it a shot!
You mean remove the storage.body file?
MR needs to be updated for 11.x please.
what you say that's a blocker for this moving forward?
Seems straight forward, nice catch.
Looking in #1637478: Add a PHP array cache backend → it was suggested ClearTest could probably be removed. Like the suggestion in #33
Will probably need test coverage
Before I ping a sub maintainer whats trying to be accomplished here? As in why is this change needed.
Rebase after blocker seems good!
Not sure which to review as there are 2 MRs but both have test failures
Ran test only job here https://git.drupalcode.org/issue/drupal-3498038/-/jobs/5941301
1) Drupal\Tests\Core\DependencyInjection\YamlFileLoaderTest::testParseDefinitionsWithProvider
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "example_service_closure_shorthand" has a dependency on a non-existent service ">example_service_1". Did you mean one of these: "example_service_1", "example_service_2"?
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:116
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:123
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:83
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:84
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:48
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:93
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:48
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:84
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:48
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:45
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:39
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
/builds/issue/drupal-3498038/vendor/symfony/dependency-injection/ContainerBuilder.php:813
/builds/issue/drupal-3498038/core/tests/Drupal/Tests/Core/DependencyInjection/YamlFileLoaderTest.php
Change makes sense and CR is clear.
Don't see any open threads so LGTM
So open threads on the MR.
Since there's been no follow up in 3+ months going to close this one out. If still a valid task please re-open.
Thanks!
wanted to bump this one more time if still relevant?
Since there's been no follow up in 3+ months going to close this one out. If still a valid task please re-open.
Thanks!
Wanted to bump 1 more time.
Since there's been no follow up in 3+ months going to close this one out, if still a valid feature please re-open maybe updating the summary
Thanks!
Since there's been no follow up in 3+ months going to close this one out, if still a valid feature please re-open maybe updating the summary
Thanks!
So what should the scope of this issue be? Config cleanup?
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Postponed issue landed
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Still relevant?
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
smustgrave → created an issue.
@cilefen seems steps were added?
Seems like something that probably needs framework manager signoff
Since there's been no follow up closing out.
Should this be moved back to NW?
Came up as a daily BSI triage target.
Summary seems good. MR will have to be updated to 11.x and a test case added.
wanted to bump one more time if we want to move back to active?
MR appears to be against 9.5 but should be 11.x
Appears to be missing test coverage
Closing out D7 tickets.
smustgrave → created an issue.
I haven't been able to reproduce this one.
Thanks for consideration, I'm helping get a D11 release as this module as kinda been let go. Don't think taking on a new sub-module is in the cards.
Been no movement in 5 years not sure there's a need?
Closing out D7 issues.
Working on a 3.0.0 release right now
smustgrave → created an issue.
This was marked as a duplicate to check the parent issue
Appears to have already been done and it's now in FieldStorageDefinitionInterface
Wanted to bump 1 more time.
Since there's been no follow up in 3+ months going to close this one out. If still valid please re-open
Thanks!
Since there's been no follow up in 3+ months going to close this one out. If still valid please re-open
Thanks!
Since there's been no follow up in 3+ months going to close this one out. If still valid please re-open
Thanks!
Wanted to bump 1 more time.
Since there's been no follow up in 3+ months going to close this one out. If still valid please re-open
Thanks!
This still needs a summary update with concrete steps.
Since there's been no response to #3 going to close this feature request out. If still valid please re-open.
Has anyone been able find exact steps?
Since there's been no follow up to #19 going to close out. Crediting @catch for the response
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Should this be unpostponed
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Assuming still valid?
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Feedback appears to be addressed for this one.
Updated comment sorry!
With recipes now aren’t profiles kinda being phased out
Summary update and steps to reproduce still appear to be missing
Has pipeline issues
Feedback appears to be addressed
Can you turn the patch to an MR
If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
We don’t really merge in fixes and push test coverage unless it’s critical which this does not count, sorry
Good catch! Can we add that back please
Possible to get a test case showing the issue please
Came here from 📌 Deprecate block_content_add_body_field Active for that trait :)
Didn't close the threads but didn't want to ignore them, with regards to the moderation tests maybe we open a follow up for cleaning up strings that we aren't asserting or removing assertions that really aren't needed.
The trait is a great idea!
I see no open questions so believe this one is ready
Personally don’t see why the comment change was needed. Read fine before
Patches should be in MRs for his project probably needs gitlab file too