🇺🇸United States @smustgrave

Sure added to the README and module page.

probably right status

@alansaviolobo are you able to address 📌 Set default version on GitLab to 3 Active

Wanted to bump 1 more time.

Since there's been no follow up going to close out. If still needed please re-open

Thanks all

Wanted to bump 1 more time as a major.

Still seems valid but not sure I see anyone picking it up..

wanted to bump this meta 1 more time.

Since there's been no follow up and as a feature request going to close out. Can always be re-opened

Thanks all!

Since there's been no follow up going to close out. If still needed please reopen

Thanks all!

Believe to still be valid.

Since there's been no follow up going to close out. Also wondering with the introduction of recipes if that could cover this scenario?

Wanted to bump this request 1 more time before closing.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for reporting this problem. We rely on issue reports like this one to resolve bugs and improve Drupal core.

Since there has been no activity here for over 8 years we are asking if this problem persists on a currently supported version of Drupal. To help, add a comment explaining if the problem still occurs or not. Any extra detail you can provide can help others who experienced this.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Believe blocker has since landed.

Assuming there would be failures if this caused issues.

Lets see if anything can be done.

So should this be closed now? or rescoped.

Can any confirm #21?

@nicxvan for ✨ Make Search Field for Module Install/Uninstall usable Postponed: needs info

Take your time I’m always 200 issues behind on review :)

Since it was mentioned this could break things maybe we should turn to a configuration option

I’ll take a look. Wonder why the test didn’t pick it up. Tricky stuff

Maybe don’t have to replicate exact behavior but making sure the blocks works on page URLs that don’t match the view think should count

There may even be one we can extend

That’s if you are using npm to get the file.

Can’t really review till it’s rebased with 7.1.x but will need upgrade path and test coverage if not already there

For checkboxes?

@mstrelan you're probably good to self RTBC after that as the rest seems like good deprecations.

That's my mistake I think I was getting crossed on another ticket for route deprecations. But think deprecations have to be removed in 12 right. If the plan is to remove history in D12.

Rebased and went through a few threads but still about 20

NW as the pipeline appears to have issues.

Probably be good to get this in before the next batch modules I'd imagine.

Not sure if this plays into anything but know there's been talks for a little bit about removing nightwatch eventually.

For the follow up

Left some comments on the MR.

Can we add a test case of the collision please.

Sorry but can the IS be flushed out some

See the test.

can we add concrete steps please

Fix it

- we should specify what the fix was

These help the reviews.

Thanks!

So is it worth doing the full deprecation and leave the library for now?

Since you already reviewed are those the changes needed here? Haha

Think it would be good to have a test showing how this is a problem. Also may need to handle if the block isn’t placed on the same url as the view

$this->rankings += $this->moduleHandler->invokeAllDeprecated('Use hook_node_search_ranking() instead. See https://www.drupal.org/node/2690393.', 'ranking');

Nice! not see that one before.

CR is straight forward and seems like a good deprecation and conversion. Don't see anything off.

Is it worth doing? Not sure if anyone depends on the library but have been surprised by less.

Question will this fix an issue where if the text field is required the aria-label isn't announcing?

Brought this up in #recipes slack channel to quote

Two, default has already been used in a release, it’s part of the API, so changing it to default_value would break a lot of existing recipes in the wild unless we do deprecation. It’s not worth it for a simple naming like this. And besides, I see a lot of changing default to default_value, rather than fallback to default_value(which is what the issue title and summary promise), so it’s just a mess

The justification here doesn't seem to out weigh the complexity that would be needed, so for me this should be closed (won't fix) but will put here first.

Feedback appears to be addressed here.

Looking at the current steps I don't see how shortcuts is needed. Note toolbar is being deprecated from core and Shortcut is up for discussion 🌱 [Policy] Move Shortcut module to contrib Needs review so may not want to mix their tests.

Save and edit has worked fine for me for a few projects. Maybe this should be closed and re-opened if the issue you mentioned @catch ever gets a decision.

Wanted to bump 1 more time before closing.

Could we get a simple test case for it?

Only question is do we need to deprecate from the node module?

In that case backporting to 10.6 should be fine I'd assume.

Seems straight forward. Feel free to ping me these if you ever need.

Lets move #26 to a follow up. Can RTBC after that

Feedback for a new name appears to be addressed Thanks!

Per Mike Gifford in #accessibility

Sounds still relevant! Thanks for following up

Tempted to just merge this one as the input should have something hidden or not but only because can't think what the complete solution would be.

Spot checking a few of those and they don't appear to be bef keys.

Maybe after 7 years got it right?

smustgrave → created an issue.

Go for it! may be able to extend one of the views for a test too

wanted to follow up on this one if still a bug on 7.1.x?

Tried replicating on 7.1.x and not able to trigger the error can the steps be more flushed out please.

smustgrave → made their first commit to this issue’s fork.

We pull this from noUiSlider JS project.

Before

Without the MR this is what I see

After applying

So removing the Needs manual tag.

Most of the feedback appears to be addressed, left 1 thread open. But the issue appears to be fixed.

Would assume disabling the phpcs check for those should be fine is there another way to confirm though?

Hiding patches while I'm at it

Thanks!

@rajab natshah seems you opened the 2nd MR 12460 can you mention what you are doing different from the original MR 7008 to help compare for review? Whichever is the correct MR though needs to update deprecation to 11.3 please

Thanks

Left 2 small comments on the MR and did bump to 11.3 from 11.2

Also ran the test only job here https://git.drupalcode.org/issue/drupal-3532741/-/jobs/6545599

1) Drupal\Tests\workspaces\Functional\WorkspaceSwitcherTest::testSwitchingWorkspaces
Failed asserting that false is not false.
/builds/issue/drupal-3532741/core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php:82
FAILURES!
Tests: 3, Assertions: 40, Failures: 1.

@amateescu probably good to self RTBC this for the few comments I left.

Seems straight forward based on the others.

smustgrave → created an issue.

Just tested on D11 + new 3.0.x branch and the block renders just fine for me. If there is additional steps to reproduce please re-open

Thanks

Don't believe this applies to the new 3.0.x branch as it's using specific classnames now.

With D7 EOL closing out old D7 issues. If still an issue on the new 3.0.x branch please re-open

Will have to see what still applies or needed for new 3.0.x branch.

Will need to see what still applies for new branch 3.0.x

Starting a new 3.0.x branch so MR will need to be updated for that please.

Starting a new branch for D11 will have a release soon.

With D7 EOL closing out old D7 issues. If still an issue on the new 2.0.x branch please re-open

With D7 EOL closing out old D7 issues. If still an issue on the new 2.0.x branch please re-open

With D7 EOL closing out old D7 issues. If still an issue on the new 2.0.x branch please re-open