🇺🇸United States @smustgrave

Can you turn the patch to an MR

If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

We don’t really merge in fixes and push test coverage unless it’s critical which this does not count, sorry

Good catch! Can we add that back please

Possible to get a test case showing the issue please

Came here from 📌 Deprecate block_content_add_body_field Active for that trait :)

Didn't close the threads but didn't want to ignore them, with regards to the moderation tests maybe we open a follow up for cleaning up strings that we aren't asserting or removing assertions that really aren't needed.

The trait is a great idea!

I see no open questions so believe this one is ready

Personally don’t see why the comment change was needed. Read fine before

Patches should be in MRs for his project probably needs gitlab file too

Duplicate of https://www.drupal.org/project/tour/issues/3489075 📌 Integrate with navigation top bar Postponed ?

Perfect timing as the site I need to do this update is coming back around. It’s been 2 weeks

Ran test-only feature https://git.drupalcode.org/issue/drupal-1587536/-/jobs/5897064 which shows the coverage.

Believe the rest of the feedback here has been addressed too.

Added another small thread.

Not sure I follow why https://www.drupal.org/project/drupal/issues/2036219 is no longer needed.

been about 2 months should we get framework manager first?

Left a comment in the MR.

Left comments on MR.

Been a while but still think this should probably be a feature request and a configuration option as this could break existing sites.

Shouldn't these keys be deprecated?

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Didn't see any MR to review?

Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

Thanks

One more bump

Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

Thanks

I have not seen any issues from this company in some time, think this could probably be closed.

smustgrave → created an issue.

wanted to bump this one more time, but not 100% sure I understand the task?

Wanted to bump this one more time.

Right but that feature is generic to checkboxes in general and doesn't do any additional searches.

Example BEF doesn't add the count next to each checkbox facets does that. So if this functionality sounds like it's only for search stuff and I still think probably in the facet plugins.

Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

Thanks

Since there's been no follow up in 3+ months going to close this one out. If still valid task please re-open.

Thanks

With the introduction of Drupal CMS this is probably outdated. Imagine minimal will be going away in general.

This came up as a daily BSI target

Is it only possible to replicate with s3? I don't have a free one I can verify with but would be good to check if still an issue.

Moving to NW as this still seems relevant.

Since there's been no follow up to above, going to close this one out. If still a bug please re-open addressing #4

Since there's been no follow up to reproduce this going to close out. If still an issue in D11 please re-open updating summary.

Bumping 1 more time.

Wanted to bump this one more time

Seems straight forward

Seems we don't need a 10.6 so just going to RTBC

I'm moving to NW as there was already an MR with no explanation for the new one

Doesn't appear anything to review

Can we get a test case showing the problem.

Sure, going to keep assigned to me then as I hope the blocker will land soon

Hello,

This appears to still need an issue summary update using the standard template

Funny enough if you disable title then order becomes

Display text
Advanced
Link URL

Which also seems odd.

smustgrave → created an issue.

With my javascript eyes on this seems like a good conversion, leaning on tests that active-link.js breakage would show.

Also did a small search locally about how hard it would be to remove and most references in our tests seem to be in migrations and uninstall/re-install tests.

Sure no problem.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Is this one still relevant?

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Feedback from xym appears to be addressed, saving credit for xjm review in the MR.

Wanted to give this one 1 more bump.

Since there's been no follow up in 3+ months going to close this one out.

Thanks!

Since there's been no follow up in 3+ months going to close this one out, but if still a desired feature please re-open.

Thanks!

Since there's been no follow up in 3+ months going to close this one out, but if still a desired feature please re-open.

Thanks!

Since there's been no follow up in 3+ months going to close this one out, but if still a desired feature please re-open. Believe this is already possible with the CAPTCHA module too.

Thanks!

Since there's been no follow up in 3+ months going to close this one out, but if still a desired feature please re-open.

Since there's been no follow up in 3+ months going to close this one out, but if still a desired feature please re-open. This one will need a summary update.

Thanks!

Wanted to give 1 more bump as I suspect this could still be relevant

Bumping 1 more time.

Before I close out do we feel this functionality needs to be in core at all?

Someone just reported they got this error during drush updb

bumping 1 more time, I don't have an answer to #5 but don't want to close just yet.

Came up as a daily BSI

Still seems to be relevant but would it be a feature request now though?

Going to give 1 more bump before closing.

Seems straight forward

Thanks @quietone

Appears to have pipeline issues, also shouldn't we use t()

Seems to be doing more then updating a message, seems like a new check that should have test coverage.

Can deprecations be updated for 11.3

Should the tests be expanded to test for internal: also?

Seems like a good conversion to me.

Shouldn't _update_cron_notify be moved too so the .inc file can be removed?

seems to need a phpstan update

Should be in an MR and will need test coverage but MR will show if it broke anything.

Thinking of picking this one back up but before I do are we convinced it will be merged? When I opened this recipes weren’t a think

https://www.drupal.org/project/block_content_template →

Is still around

Wanted to bump this again about potentially removing in D12 if that window isn’t closed?