Live feed

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

shawn dearmond → opened merge request !55

I'll wait for others to chime in before updating in case there are some other things

Feedback from Gábor via Slack:

Gábor Hojtsy (he/him)
1 hour ago
"large number of Drupal AI sessions" => "significant AI sessions" IMHO is a better, not sure it should be about the number but about the quality IMHO :slightly_smiling_face:
10:46
Timing of this is very event dependent IMHO -- eg. an international event, two weeks before is way too late to book travel, etc. can we generalize it? "They would write one a couple of weeks before the event highlighting the AI focus, and one within two weeks of the event with a recap"
eg. "They would write one weeks before the event (well timed for promotion) highlighting the AI focus, ..." (rest is good)
10:47
One more thought: would this form be used to try to lure AI speakers into specific events or is that supported somehow else. I can see an event wanting to do a good chunk of AI content but needing suggestions or speakers/ready made talks that we can refer :slightly_smiling_face:

Gábor Hojtsy (he/him)
40 minutes ago
Otherwise looks good, thanks for doing this!

kristen pol → credited gábor hojtsy → .

Automatically closed - issue fixed for 2 weeks with no activity.

@annmarysruthy -- Thanks again for your work on this and for your explanation; that's very helpful.

I manually applied the changes in your revised MR !12697 to my Drupal 11.2.2 site and the tabs now display in the correct order.

I agree with @sagarsingh24 that the status should now be RTBC. I updated the issue summary and changed the status.

Thank you both!

Automatically closed - issue fixed for 2 weeks with no activity.

Hello @nidhi27,

Nice work!

tedbow → created an issue.

This is a reroll of #4 that will apply against the Drupal 11 compatible version of the module 📌 Drupal 11 compatibility for lb_ux Active .

Thanks for reporting and working on this issue. #7 worked for me with Drupal 10.5.1.

It looks like you have custom templating. The class name was changed to meet coding standards. You need to change btnCopy to btn-copy in your template.

heyyo → created an issue.

Review finished and committed.

A couple comments on the MR.
CR also needs a version bump.

The only error I am seeing in composer is this:

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-02-15/3040427-42-migrate_plus_multiple_urls.patch

In Patches.php line 331:
                                                                                                                    
  Cannot apply patch Allow callback for Url source, and single item Json plugin 
            
              
              
              ✨
              Allow callback for Url source, and single item Json plugin 
                Needs work
              
             (https://www.drupal.org  
  /files/issues/2023-02-15/3040427-42-migrate_plus_multiple_urls.patch)!                                            
                                                                          

With the new Migrate tools update, I see the following error when trying to run cron:

ArgumentCountError: Too few arguments to function Drupal\migrate_tools\MigrateExecutable::__construct(), 2 passed in /code/web/modules/oho/migrate_recurring/src/MigrateRecurringService.php on line 170 and at least 5 expected in Drupal\migrate_tools\MigrateExecutable->__construct() (line 98 of /code/web/modules/contrib/migrate_tools/src/MigrateExecutable.php).

This is presumably a beta-blocker, so I'll comment on it to bump it up the list.

Before closing for good, this ticket should link to the official SDC documentation (in a comment or a section of the IS).

This seems essential - it's a bit that got left out of ✨ Fix GiftAidOverviewController Active

Without this, anonymous declarations will fail to arrive on the user, so I've altered the issue settings.

I'm happy for you to say it's not a road-map priority. Even so, I feel we should have these clearer issue settings to help us or anyone else see the status in the future.

apmsooner → made their first commit to this issue’s fork.

We've done most of these now, the rest likely aren't important.

Thanks. I will make the fixes in 📌 Tidy up Active

I kind of like having submodules for atomic features

Fine. Potentially it could use some documentation so people can find it and a test so that it has a chance of working when they do😃.

all green, had to fix a deprecation

https://git.drupalcode.org/issue/entity_print-2928222/-/pipelines/547158

We’re not aware of any general issues which would interrupt SSL connections.

We would need some more details to attempt to help, especially if it is intermittent.

(patch for version 2.1.0)

fjgarlin → opened merge request !374

fjgarlin → changed the visibility of the branch 3327584-marketplace-counts-modern to hidden.

Merged!

Now have a triple green on the test results😃. OK with you?

I have never installed the necessary for infrastructure for FunctionalJavascript tests. Probably we need just one test, so it's not really efficient for me to learn it. Would you be willing to do it yourself please?

In DeclarationFormTest::testOralDeclarationRecordedByStaff(), the return statement should be down to just before @todo Fix when added code for cancellation.. It just needs some ajax to add evidence, which might start something like

$this->assertSession()->waitForElementVisible('named', ['button', 'Add new Gift Aid evidence'])->press();

Merged! Thanks

Done, https://packagist.org/packages/drupal/ai_dev_recipe is now available

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

nicxvan → created an issue.

I was thinking about this but I'm not sure that we can do that because components can include multiple slots and we don't have the concept of a default slot. We don't know which slots these restrictions would apply to in the case that a component includes multiple slots

Totally agree.

Does someone want to share other examples, from UI components tech or display building tools?

I still think this is the way to go. We are struggling finding the perfect balance between covering the expected mechanisms and staying simple. Let's have a look on what other community are doing.

I already shared examples from Oracle Content Management and VueJS. What else can we find?

In my humble opinion, it is better to not have this feature than having a bad implementation of this feature. There is a high risk of doing something we may regret later.

I know nothing about ARIA recommendations, but on #3286466-50: Tabbing order does not satisfy 508 accessibility requirements → , @rkoller suggested using aria-pressed instead of aria-expanded:

... But i wonder if aria-expanded is the right choice for a toggle button. I always have problem as a sighted user understanding the current state for toggle buttons that change their label inbetween states. A point that Leonie Watson also illustrated in their talk for smashing magazine: https://youtu.be/OUDV1gqs9GA?t=3222 . She advocated to use aria-pressed instead. That way the button state is either pressed/selected or not and the button label remains the same between states. That way things are completely clear and unambiguous for screen reader users?

Does that apply here? Should we consider it?

@andrewmacpherson: It has been more than 5 years since you self-assigned this issue and last commented. I am un-assigning it now.

The form is now embedded:
https://new.drupal.org/ai/survey

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

This is actually by design, we don’t need to show a success message for everything that’s working. We want to use the screen real-estate to show what’s important. In this case, if there are no warnings, I don’t think you need an extra notification to read.

LDAP 4.12.0

I was not sure whether this issue is caused by the LDAP Profile module itself or the LDAP module.

Added a couple comments to MR, nothing major I think. Nice work!

joshf → created an issue.

Needs to add the Icon using the Drupal Icon API, or by other means.

bluegeek9 → opened merge request !16

Root cause found. Added explicit check for it and now throws a helpful exception. Result: many failures, because 0.x was somehow not negatively affected by this bug.

The fix is simple: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...

bluegeek9 → created an issue.

rajab natshah → opened merge request !104

rajab natshah → created an issue.

Hi @juc1 -

Yea, it could probably be documented better.

I think the missing information is implied but not stated.

You have to have a content type using taxonomy and content of that type created.

Then you fill in the form.

Then you place the block via the block admin.

It's been a while and I haven't actually verified these steps but I think I'm close. I'll verify this before updating the README.

Thank you for your time.

-- Bill Kelly

Cross off done tasks

@vinodhini.e, thanks for testing:)

Automatically closed - issue fixed for 2 weeks with no activity.

Needs to add the Icon using the Drupal Icon API, or by other means.

@sanduhrs, thank you:)

I'm changing the issue's status as fixed.

rajab natshah → opened merge request !19

Here's a draft:

https://docs.google.com/forms/d/1Fmdnw5zxFl9PJyhpkD-1Ul_V8H_LbPuhNfDjiwy...

rajab natshah → created an issue.

nicholass → opened merge request !16

@marcus_johansson Since I was in knee deep and could not extract myself, I gave it another go - blame it on obsession.

The latest commit fixes the issue when the options_select widget is used, see list-integer-sentiment-score--v2.mp4.

There may be a better place to fix this upstream, e.g. in FieldWidgetActionBase.php. Let me know.

I experimented a lot trying to get AI to use the filename, but only luck I had was by adding a token so that I can specifically include it in our prompt template. And for the images I tested this seemed to have a very beneficial effect, so this change just adds a filename token.

Along with IMPORTANT: This image has the filename "{{ filename }}" - use keywords from this filename as strong hints about the image content and incorporate relevant context into your description. it has greatly improved our images alt text. So I feel like this shouldn't be too much of a request to add this token.

As a site architect but not a system admin, it would be incredibly helpful to see this monitoring in the UI. The only time I know the cache is full is when the site goes down.

Fix deprecation notices in test results (although some come from Commerce tests?)

Whenever you like

Combine the 2 Commerce sub-modules? People might forget to enable both. I've never enabled gift_aid_commerce_product, and it has no tests. Is it needed?

I'm on the fence.

gift_aid_commerce is totally neutral about how you specify which orders need to seek a gift aid declaration. You could just put the pane on a particular donation checkout flow and have it always show there. gift_aid_commerce_product allows you to opt products in to saying they are donations and should seek a declaration if the order includes them, which is useful if the same checkout flow includes both donations and other products.

gift_aid_commerce_product is still opt-in per product even when enabled, so it could be combined. But it does add a base field to the commerce product entity type, which is a slightly invasive operation.

I'm on the fence. I kind of like having submodules for atomic features, I think of it as aiding maintainability but that's a matter of taste.

Move the menus one level down, e.g. put Gift Aid under Services? This is the normal level, and it means that the various admin pages for the module are all visible as tabs.

Sure, no opinion.

Automatically closed - issue fixed for 2 weeks with no activity.

BTW the testimonial component has the same problem, you may want to fix it here to be a div for the quote not a p too or open a new issue :) That at least is conceptually easier since the quote is not conceptualised as a "paragraph" :)

Current:

After changing to div:

Discussed the above with @catch and Slack and the feeling seems to be that I should go ahead and create that MR, then let the security team and release managers consider it.

i.mcbride → changed the visibility of the branch 3464547-drupal-11-compatibility-composer to hidden.

Need to update the Merge request against 11.x so that the PHPUnit tests pass and change the deprecation target to the next minor 11.3 and the removal as 12.

Automatically closed - issue fixed for 2 weeks with no activity.

I believe this feature will get in to core eventually (I removed the double identification of the category in the title), so I’m on board with adding it to this module as well.

The approach is important here—what do you propose?

If you start a WIP merge request, it’ll be much easier to discuss the direction in concrete terms but even a rough draft "proposed solution" helps get the conversation moving.

Thanks for review Artem!

As far as I was able to see, the chat() method in this case could just be taken from base class, I do not see any specific logic in the OpenAI provider.

What do you think Marcus?

This must come from a rule other than AP style. In fact, using an ndash is not even part of the AP style standard, but I believe that it was included at user request as an option. Can you provide any sources on why spaces should not be included?

justafish → opened merge request !188

Tested against Drupal 11.x and can confirm this is a bug. On text configuration pages, such as /admin/config/content/formats/manage/full_html, there's a JavaScript error that breaks the CKEditor toolbar, as per above.

TypeError: undefined is not an object (evaluating '[...dividers, ...available].find((button) => {
  return button.name === name;
}).id')

On a node edit page that has the text format enabled that has the CKEditor Responsive Table button added, this JavaScript errors appears.

[Warning] toolbarview-item-unavailable (2) (ckeditor5-dll.js, line 5)
Object

item: "customTable"

Object Prototype
"
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-toolbarview-item-unavailable"

The "problem" was that the template has a real HTML paragraph element for this component. Paragraphs can't contain other paragraphs or lists, so the paragraph naturally ends when you enter a list. Then the styling does not apply to that anymore. Once the wrapper is a div, not a paragraph, this is solved. Not semantically very nice but quickly fixed it :D

BEFORE

AFTER (added another list too):

Thanks Artem to take a look on this!

If it doesn't have specific logic, them I would say that we can just remove it and take the logic form base class.

justafish → changed the visibility of the branch 3535871-tokenauthuser-does-not to hidden.

gábor hojtsy → made their first commit to this issue’s fork.

chris dart → opened merge request !5