Live feed

I've been playing around with this and seems to work well, apart from if you have guest checkout enabled and "Create a new account for an anonymous order" also enabled, sometimes the new user is not created, and looking at the orders, the order remains stuck in cart.

I'll do some more testing and hopefully if I figure out what's causing it, report back.

I'm not sure this needs to be postponed any more - and that other issue may be obsolete with the new field type categories system.

Automatically closed - issue fixed for 2 weeks with no activity.

Today, I worked on this module for around 6 hours after a long time. Thinking about the state of things, I've updated the issue description. Anybody willing to help with some research is welcome to share their ideas and thoughts.

jurgenhaas → created an issue.

Thanks for the suggestion but I believe this module will go away sometime soon. Please follow this issue to stay up-to-date 💬 Deprecate the Sidr module in favor of another project Needs work .

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

I believe this might happen if you don't enable the "Disable duplicates" option. Without disabling duplicates, Sidr creates a clone of the original elements and puts them in the Sidr panel. These clones don't have any events attached to them. If you want the events to be attached, you will have to do something like this:

1. Create a hidden DIV or region (say, left-panel) that contains the markup/blocks that you want in your Sidr
2. Set up a Sidr trigger block that takes content from the above region, say, .region-left-panel
3. Finally, in the advanced settings, check the box that says "Disable duplicates".

This should preserve the event listeners attached to the original element. Since this issue is very old, I'm closing it as outdated. If you're still facing it, feel free to reopen it.

This is maybe overkill. Pondering.

We should at least document that it's fine to mix both in one array, because core does that too.

I tested it to be working today. You must've missed a step somewhere. Basically,

1. Install and configure the Composer Merge plugin
2. Run composer update --lock or composer require drupal/sidr -W

I am attaching a working composer.json file so that you can compare it with yours. If you're still face the problem, feel free to reopen this issue.

{
    "name": "jigarius/drupal-sidr",
    "description": "A Drupal site to develop and test the Sidr module.",
    "type": "project",
    "license": "GPL-2.0-or-later",
    "homepage": "https://www.drupal.org/project/drupal",
    "support": {
        "docs": "https://www.drupal.org/docs/user_guide/en/index.html",
        "chat": "https://www.drupal.org/node/314178"
    },
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }
    ],
    "require": {
        "composer/installers": "^1.9",
        "drupal/core-composer-scaffold": "*",
        "drupal/core-recommended": "^10",
        "drupal/core-vendor-hardening": "*",
        "drupal/sidr": "5.x-dev",
        "drupal/upgrade_status": "^4.3",
        "drush/drush": "^11.6",
        "wikimedia/composer-merge-plugin": "master-dev"
    },
    "conflict": {
        "drupal/drupal": "*"
    },
    "minimum-stability": "stable",
    "prefer-stable": true,
    "config": {
        "sort-packages": true,
        "allow-plugins": {
            "composer/installers": true,
            "drupal/core-composer-scaffold": true,
            "drupal/core-vendor-hardening": true,
            "wikimedia/composer-merge-plugin": true
        }
    },
    "extra": {
        "drupal-scaffold": {
            "locations": {
                "project-root": "./",
                "web-root": "web/"
            },
            "allowed-packages": [
                "drupal/core"
            ]
        },
        "installer-paths": {
            "web/core": [
                "type:drupal-core"
            ],
            "web/libraries/{$name}": [
                "type:drupal-library"
            ],
            "web/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            "web/profiles/contrib/{$name}": [
                "type:drupal-profile"
            ],
            "web/themes/contrib/{$name}": [
                "type:drupal-theme"
            ],
            "drush/Commands/contrib/{$name}": [
                "type:drupal-drush"
            ],
            "web/modules/custom/{$name}": [
                "type:drupal-custom-module"
            ],
            "web/profiles/custom/{$name}": [
                "type:drupal-custom-profile"
            ],
            "web/themes/custom/{$name}": [
                "type:drupal-custom-theme"
            ]
        },
        "merge-plugin": {
            "include": [
                "web/modules/contrib/sidr/composer.libraries.json"
            ]
        }
    }
}

Rajab Natshah → created an issue.

Automatically closed - issue fixed for 2 weeks with no activity.

NW for Phenaproxima's comments.

mstrelan → closed merge request !6400

Yes - I'll write something on Monday in the Change Record :)

I guess, here is some good news:

The integration with the Gin theme has been improved, and we gain 2 improvements from that:

• The positioning of the action buttons is now handled by Gin and no longer tweaked by bpmn_io. That said, it should now always be correct.
• The property panel is now moved into the sidebar. This makes things arranged in a better way and on mobile, the sidebar is handled by Gin such that it can be toggled on and off to overlap the main content.

Hope, you all like this change and I will now also back port that into version 1.1

Added tests for the new UriHost constraint. Note that filter_var($value, \FILTER_VALIDATE_DOMAIN, \FILTER_FLAG_HOSTNAME) accepts every valid IPv4, thus removed the explicit call to filter_var($value, \FILTER_VALIDATE_IP, \FILTER_FLAG_IPV4).

Automatically closed - issue fixed for 2 weeks with no activity.

Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

jrockowitz → created an issue. See original summary → .

mondrake → opened merge request !30

mondrake → created an issue.

Automatically closed - issue fixed for 2 weeks with no activity.

Pushed one more commit to remove a bc layer for chromeOptions in PerformanceTestTrait which didn't trigger its own deprecation because we already had one for the same thing elsewhere, but is no longer necessary once we don't support it. Trivial change so as long as gitlab comes back green I'll go ahead and commit this one once it has.

@teknocat great discovery, let's merge this! 👏

catch → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.

daffie → opened merge request !15

daffie → created an issue.

Automatically closed - issue fixed for 2 weeks with no activity.

Committed/pushed to 11.x and cherry-picked to 11.0.x/10.4.x/10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake → opened merge request !21

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks for reporting this issue. It turns out that while replacing jQuery once with Drupal core's once had resulted in several bugs including this one. This issue should not be there in the latest 5.x branch.

@isalmanhaider thanks for your interest in the proposed resolution.

@smustgrave the existing tests failure was related. I have fixed it.

Status needs to remain "needs work" because of all the other remaining tasks to discuss/to do (implementing new tests is of course among the remaining points).

joachim → created an issue.

Thanks for reporting this issue. When the Sidr opens, it tries to set focus on the first input or anchor element inside the Sidr panel to help with keyboard navigation and the contextual links were stealing this focus so they were hidden away.

To resolve this issue in a nicer way, focus is now granted to the first non-contextual-link in the Sidr panel. The change will be released in the next 5.x version.

I'm going to file a follow-up for splitting the settings method into field settings & storage settings.

Tested it locally and all works. Committed.

Thanks for reporting and working on this!

To prevent this issue from stalling, it would be amazing if someone with the right skills could check locally with Composer if the scaffolding in the patch:

1. Creates a .gitignore
2. Which is not overwritten/updated

Thanks for reporting this issue. I noticed that there were some anomalies in the JS related to the once() usage. I have fixed those. Additionally, I've made it such that when a Sidr closes, if the focus is still inside the Sidr panel, then the focus is sent back to the last used Sidr trigger.

As for the aria-hidden, I realized that when the Sidr panel is closed, it shouldn't be visible on the browser nor for assistive technologies. Hence, I've used hidden="hidden" to hide them away for good. For reference, here's a difference between hidden and aria-hidden.

As for the other suggestion, however, I believe it is time for this module to be replaced with some other module. I am looking for a project that would replace this Sidr module 💬 Deprecate the Sidr module in favor of another project Needs work .

fbocanegra → created an issue.

It seems that simply changing the extension doesn't preserve the good formatting for md files. I think they need to be updated to the correct formatting for code, tables, links, etc. This will further improve the visual perception and usability

fbocanegra → opened merge request !5

pdureau → created an issue.

fbocanegra → changed the visibility of the branch 1.0.x to hidden.

This is not yet included in the default coding standards pipeline from Drupal. So please report what version you're using to get this report.

@shivamsen_12579 why are you taking an issue that is assigned to someone else? Please allow someone who is assigned to an issue to actually work on it.

tim-diels → closed merge request !32

Adding SKIP_ESLINT: '1' is not correct as we would actually want to run that.
Also this issue is outdated as this has been picked up within another issue and got merged.
Thanks for the work, sorry that I'm not including this from this issue.