- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
about 2 hours ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
about 2 hours ago Waiting for branch to pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 2 hours ago Waiting for branch to pass - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
about 2 hours ago Waiting for branch to pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- @project-update-bot opened merge request.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- @project-update-bot opened merge request.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- First commit to issue fork.
- 🇷🇸Serbia bojanz
Look at comment #3, the commit was made on "16 March 2024 at 14:23", so that seems to match?
- First commit to issue fork.
- f14f678c committed on 8.x-1.x
Issue #3450990: Automated Drupal 11 compatibility fixes for csv_importer
- f14f678c committed on 8.x-1.x
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This issue should be only for automated fixes. Other fixes should be in a separate issue.
- 🇮🇹Italy itamair
Hi @here!
and sorry if I couldn't sync and stay on track with this ... BIT I had other priorities.
I could see some improving commits till some days ago, even after this was tagged as RTBC.I wouldn't really re-review and QA all this, as I can already see many strong Drupal devs on this.
Hence, are we sufficiently confident in merging this MR into the 8.x-1.x dev branch and deploy a new geofield 8.x-1.58 release, compatible with Drupal 11??? Automatically closed - issue fixed for 2 weeks with no activity.
-
chr.fritsch@gmx.net →
committed bfa17df6 on 1.0.x
Issue #3435776 by chr.fritsch@gmx.net, Project Update Bot, daniel.bosen...
-
chr.fritsch@gmx.net →
committed bfa17df6 on 1.0.x
- last update
about 7 hours ago 7 pass Automatically closed - issue fixed for 2 weeks with no activity.
- last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - last update
about 8 hours ago 7 pass - 45983d16 committed on 10.1.x
Issue #3434349: Automated Drupal 11 compatibility fixes for...
- 45983d16 committed on 10.1.x
- last update
about 8 hours ago 7 pass - @chrfritschgmxnet opened merge request.
- 🇩🇪Germany chr.fritsch 🇩🇪🇪🇺🌍
chr.fritsch@gmx.net → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇬🇧United Kingdom Eli-T Manchester
Thanks for testing @rodrigoaguilera 💙
New release supporting Drupal 11 available at https://www.drupal.org/project/uploaded_file_filename_randomizer/release... →
- 🇦🇹Austria maxilein
Development version: 2.0.x-dev updated 16 Mar 2024 at 14:23 UTC
it can't be there. Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- last update
about 10 hours ago Composer require failure - last update
about 11 hours ago Composer require failure - 🇵🇹Portugal jcnventura
@MegaChriz, your module and I do agree with not bumping version numbers needlessly. However, if you're introducing breaking changes, a major bump is justified. And for me, dropping support for Drupal 9 is one such BC break (assuming you're still going to do that as per #16).
Even if the MR is not yet dropping Drupal 9.3, it is a possible easy solution for my comments on the MR. The other possible solution (adding PHP 8 as a minimum) is also a BC-break.
- 🇨🇦Canada mandclu
Expanded the changes to include all info.yml files, and to remove all use of default_argument_skip_url since support for this was officially removed in https://www.drupal.org/node/981870 →
Merged in, but moving this issue back to Active so it can receive additional patches, if needed.
- 🇹🇷Turkey Orkut Murat Yılmaz
I assume that it would be better to support D11 with new version.
- 🇹🇷Turkey Orkut Murat Yılmaz
I've tested @gg24's MR locally and it works. Thanks for refactoring the code and modernizing the README file.
- last update
about 11 hours ago 3 pass - 🇹🇷Turkey Orkut Murat Yılmaz
I've tested the changes by manually editing the info file.
- 🇹🇷Turkey Orkut Murat Yılmaz
@bojanz, can you commit this to the stable branch too?
Automatically closed - issue fixed for 2 weeks with no activity.
-
mstrelan →
committed ed1db6c5 on 8.x-2.x authored by
Project Update Bot →
Issue #3428167 by Project Update Bot, mstrelan: Automated Drupal 11...
-
mstrelan →
committed ed1db6c5 on 8.x-2.x authored by
Project Update Bot →
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇪🇸Spain rodrigoaguilera Barcelona
Just tested manually the patch in a Drupal 11.0.0-beta1 installation and I can confirm it works as expected.
Please roll a release with this patch included Automatically closed - issue fixed for 2 weeks with no activity.
- 🇳🇱Netherlands timohuisman Leiden, Netherlands
I've checked MR !23 against drupal/core 11 and drupal/views_infinite_scroll 2.0.2, found no errors. Back to RTBC.
-
Grimreaper →
committed cbf0d67d on 8.x-1.x
Issue #3434734 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed cbf0d67d on 8.x-1.x
- First commit to issue fork.
- @grimreaper opened merge request.
-
Grimreaper →
committed 90d6315f on 8.x-1.x
Issue #3429848 by jnicola, Grimreaper: Automated Drupal 11 compatibility...
-
Grimreaper →
committed 90d6315f on 8.x-1.x
- @grimreaper opened merge request.
- 🇩🇪Germany Gogowitsch
I am leaving this issue open so that the bot can add more comments and patches.
-
Gogowitsch →
committed bc82b9b5 on 8.x-1.x
Issue #3451221: Mark module as compatible with Drupal 11
-
Gogowitsch →
committed bc82b9b5 on 8.x-1.x
- 🇮🇳India naveenvalecha New Delhi
Postponed on 📌 Automated Drupal 11 compatibility fixes for metatag Needs review
Automatically closed - issue fixed for 2 weeks with no activity.
-
kaszarobert →
committed 96b98c2b on 1.0.x
Issue #3434395 by Project Update Bot: Automated Drupal 11 compatibility...
-
kaszarobert →
committed 96b98c2b on 1.0.x
Automatically closed - issue fixed for 2 weeks with no activity.
-
kaszarobert →
committed 68e478e0 on 1.0.x
Issue #3429586 by Project Update Bot: Automated Drupal 11 compatibility...
-
kaszarobert →
committed 68e478e0 on 1.0.x
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
On a D11-beta1 site an exception occurs on the /admin/structure/types/manage/{entitytypeid}/fields/add-field page:
AssertionError: "Key / Value" must be defined in MODULE_NAME.field_type_categories.yml in assert() (line 183 of core/lib/Drupal/Core/Field/FieldTypePluginManager.php). Drupal\Core\Field\FieldTypePluginManager->getGroupedDefinitions() (Line: 131) Drupal\field_ui\Form\FieldStorageAddForm->processFieldDefinitions() (Line: 80) Drupal\field_ui\Form\FieldStorageAddForm->buildForm() call_user_func_array() (Line: 528) Drupal\Core\Form\FormBuilder->retrieveForm() (Line: 279) Drupal\Core\Form\FormBuilder->buildForm() (Line: 73) Drupal\Core\Controller\FormController->getContentResult() call_user_func_array() (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593) Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183) Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53) Drupal\Core\StackMiddleware\Session->handle() (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36) Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 705) Drupal\Core\DrupalKernel->handle() (Line: 19)
Automatically closed - issue fixed for 2 weeks with no activity.
- last update
2 days ago 15 pass - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.
- last update
2 days ago 15 pass - @balu-ertl opened merge request.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Based on the answers on this Slack thread, I have the conclusion that it's not strictly necessary to rely on the
DeprecationHelper::backwardsCompatibleCall()
utility. I assume the module maintainers probably still plan to continue supporting D9, in which this deprecation handling solution was not present yet and thus would have no effect anyway.Although the change record → about the deprecation of
watchdog_exception()
suggests using\Drupal\Core\Utility\Error::logException()
but for me, it still seems to be just another wrapper around the\Drupal\Core\Logger\LoggerChannel::log()
.Therefore I simplified exception logging with a more informative solution I peeked from core's
\Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::makeSubrequest()
. As both methods are marked as static, thus we cannot rely on the central dependency injection to obtain a logger channel service. - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.
- @balu-ertl opened merge request.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
For better clarity why the changes suggested by the Upgrade Bot were not considered: for some reason, the MR was created against the non-default
2.1.x
branch. The file structure is different on the default3.0.x
branch and similar files already have the fixes the Bot suggested.However, I still felt the need to reopen this ticket, because (independently from the Bot's minor coding standard points) the 3.0.0-alpha1 → version installed on a D11-beta1 site runs into an error when visiting its config page:
“ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/stage_file_proxy/src/Form/SettingsForm.php on line 26 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 41 of core/lib/Drupal/Core/Form/ConfigFormBase.php).”
As being relatively easy to fix in the form constructor, I opened a second MR on a different branch of this repo.
- @balu-ertl opened merge request.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Scan report of Upgrade Status says:
“
tests/eva_test/config/install/views.view.2873385_eva.yml:198
Support from all Views contextual filter settings for thedefault_argument_skip_url
setting is removed fromdrupal:11.0.0
. No replacement is provided. See the deprecation notice → .”Module manually tested (installing, configuring, uninstalling) on a D11-beta1 site without problems:
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.
- @balu-ertl opened merge request.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇳🇱Netherlands MegaChriz
@MegaChriz when you merge this, it might make sense to create a 4.x branch, and to tag a 4.0.0-alpha1 version when you add D11 support. This would allow you to keep adding changes to the 8.x-3.x branch in the case that something critical should happen, and to pivot Drupal 10 and 11 to fully use semantic versions.
@jcventura
Yeah, I would love to get semantic versioning for this reason, but a few people strongly adviced me to not create a new major version because that would slow down adoption of the new version + it creates an extra hurdle for people who want to upgrade to a new major Drupal version, Drupal 11 in this case.For details, see https://drupal.slack.com/archives/C014CT1CN1M/p1659448352144959
See also https://medium.com/jakob-on-drupal/dont-go-making-major-version-changes-...Anyway, I'm on holiday soon, so I'll probably not be able to commit this shortly - unless I've got so much bad weather on location that I just want to work on Feeds.
- last update
2 days ago 10 pass - last update
2 days ago 10 pass - 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- last update
2 days ago 10 pass - last update
2 days ago 10 pass - First commit to issue fork.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
2 days ago Not currently mergeable. - @ankitv18 opened merge request.
- 🇮🇳India ankitv18
Updated the MR and enabled the next major pipeline, please review the MR!173
Created new issue to support book and laminas-feed tests and fix all deprecated method introduced in phpunit 10
https://www.drupal.org/project/feeds/issues/3454788 📌 PHPunit Next Major pipeline failure Activecc: @MegaChriz
- last update
2 days ago Composer require failure - last update
2 days ago Composer require failure - last update
2 days ago Composer require failure -
Grimreaper →
committed e6bbabf9 on 8.x-1.x
Issue #3429840 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed e6bbabf9 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.
- @grimreaper opened merge request.
- last update
2 days ago Composer require failure -
Grimreaper →
committed 6cbfe81f on 8.x-1.x
Issue #3429556 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed 6cbfe81f on 8.x-1.x
- @grimreaper opened merge request.
- last update
2 days ago Composer require failure - last update
2 days ago Composer require failure - last update
2 days ago Composer require failure - last update
2 days ago 20 pass - 🇮🇳India ankitv18
Now pipeline is failing on https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1867677#L102
So I believe we can't run the tests below D10 cause of return type hint ofpublic function normalize($object, $format = NULL, array $context = []): array|bool|string|int|float|null|\ArrayObject {
Dropping the D9 from info.yml, phpcs:ignore for comma trailing and previous major from gitlabcc: @bbrala @ptmkenny
- last update
2 days ago 20 pass -
Grimreaper →
committed a88d5926 on 2.0.x
Issue #3428855 by smustgrave, Grimreaper: Automated Drupal 11...
-
Grimreaper →
committed a88d5926 on 2.0.x
- 🇮🇳India ankitv18
for phpunit previous major: https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1867426#L217 (These are the failing)
Reason: to avoid phpcs issues like this: Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma
There are many places where comma separator is added at the end of closing statement in the constructor (These changes taken place couple of weeks ago).So do we need that change or we can remove comma separator from those places and add phpcs:ignore Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma above last argument in the method.
cc: @bbrala
- @grimreaper opened merge request.
- last update
2 days ago 20 pass - last update
2 days ago 20 pass - last update
2 days ago 20 pass - last update
2 days ago 20 pass Automatically closed - issue fixed for 2 weeks with no activity.
- First commit to issue fork.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Reviewed and tested (module install, configuring, trying out, uninstalling) on a D11-beta1 site, found working as expected:
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Re: #7 📌 Automated Drupal 11 compatibility fixes for imagefield_slideshow Fixed
Confirming that the images uploaded into the field are animating with the 2.0.5 version of the module on a D11-beta1 site.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- 🇮🇳India ankitv18
Updated the MR and fixes remaining type hint, validated on local by installing the module.
- last update
3 days ago 20 pass - last update
3 days ago 20 pass - last update
3 days ago 20 pass - last update
3 days ago 20 pass - last update
3 days ago 20 pass Automatically closed - issue fixed for 2 weeks with no activity.
- last update
3 days ago 9 pass, 6 fail - last update
3 days ago 9 pass, 6 fail - last update
3 days ago 18 pass, 2 fail - last update
3 days ago 18 pass, 2 fail - last update
3 days ago 20 pass - last update
3 days ago Composer require failure - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Based on the answers on this Slack thread, I have the conclusion that it's not strictly necessary to rely on the
DeprecationHelper::backwardsCompatibleCall()
utility. I assume the module maintainers probably still plan to continue supporting D9, in which this deprecation handling solution was not present yet and thus would have no effect anyway.Albeit the change record → about the deprecation of
watchdog_exception()
suggests using\Drupal\Core\Utility\Error::logException()
but for me it still seems to be just another wrapper around the\Drupal\Core\Logger\LoggerChannel::log()
.Therefore I simplified exception logging with a more informative solution I peeked from core's
\Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::makeSubrequest()
. - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - 🇮🇳India chandu7929 Pune
@ankitv18 - I can see issue when enabling this module on Drupal 11.
PHP Fatal error: Declaration of Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /Users/chandan.singh/Sites/D11/web/modules/contrib/jsonapi_extras/src/Normalizer/JsonApiNormalizerDecoratorBase.php on line 58 Fatal error: Declaration of Drupal\jsonapi_extras\Normalizer\JsonApiNormalizerDecoratorBase::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /Users/chandan.singh/Sites/D11/web/modules/contrib/jsonapi_extras/src/Normalizer/JsonApiNormalizerDecoratorBase.php on line 58 [warning] Drush command terminated abnormally.
- 🇵🇹Portugal jcnventura
@MegaChriz when you merge this, it might make sense to create a 4.x branch, and to tag a 4.0.0-alpha1 version when you add D11 support. This would allow you to keep adding changes to the 8.x-3.x branch in the case that something critical should happen, and to pivot Drupal 10 and 11 to fully use semantic versions.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → changed the visibility of the branch project-update-bot-only to hidden.
- @balu-ertl opened merge request.
- 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
Balu Ertl → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure Automatically closed - issue fixed for 2 weeks with no activity.
- 🇳🇱Netherlands MegaChriz
It looks like that some new phpcs issues are introduced with the code changes. We could consider to resolve 🐛 Fix PHPStan errors Needs work first, to also possible catch newly added phpstan issues.
Anyway, needs work. I think that at least tests must pass on Drupal 11 before merging it. Else there would be a risk to release something as D11 compatible while it may still have some incompatibility.
- 🇮🇳India Vishal Choudhary Dharmshala
I have Reviewed the project bot branch code and the same branch code clone in the Drupal11 setup its working fine for me
so, Move to RTBC.
Thanks Automatically closed - issue fixed for 2 weeks with no activity.
- last update
3 days ago 119 pass, 2 fail - last update
3 days ago 120 pass - 🇩🇪Germany jurgenhaas Gottmadingen
I've added Drupal 11 to the supported core versions in the info file as well.
- First commit to issue fork.
- 🇮🇳India ankitv18
@MegaChriz I've noticed you pushed logException Method few days back: https://git.drupalcode.org/project/feeds/-/merge_requests/127/diffs#a56d...
And going through the feeds.services.yml below logger is already there.logger.channel.feeds: parent: logger.channel_base arguments: ['feeds']
In this MR I used direct drupal call using \Drupal::logger('feeds')->error($e) instead of watchdog_exception
For PhpassHashedPassword deprecation I've replaced it with a https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Password%... - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
3 days ago Composer require failure - last update
4 days ago Composer require failure - last update
4 days ago Composer require failure - last update
4 days ago Composer require failure - last update
4 days ago Composer require failure - 🇮🇳India ankitv18
There's already a separate issue where all the phpstan fixes are considered. Please check below issue
https://www.drupal.org/project/feeds/issues/3425218 🐛 Fix PHPStan errors Needs work - 🇮🇳India deepakkm
There are few deprecation which should be fixed as part of this ticket
Instantiation of deprecated class Drupal\Core\Password\PhpassHashedPassword: in drupal:10.1.0 and is removed from drupal:11.0.0. The password compatibility service has been moved to the phpass module. Use \Drupal\phpass\Password\PhpassHashedPassword instead.
- 🇮🇳India deepakkm
Rebased MR !173 with 8.x-3.x branch. Verified changes locally and looks good to me.
- last update
4 days ago Composer require failure Automatically closed - issue fixed for 2 weeks with no activity.
- First commit to issue fork.
- @ankitv18 opened merge request.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- last update
4 days ago 59 pass - @ankitv18 opened merge request.
- 865c484c committed on 3.0.x
Issue #3434633 by Project Update Bot: Automated Drupal 11 compatibility...
- 865c484c committed on 3.0.x
-
joelpittet →
committed 84ea6bc9 on 2.x
Issue #3434540: Automated Drupal 11 compatibility fixes for...
-
joelpittet →
committed 84ea6bc9 on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇭Switzerland Berdir Switzerland
Merged. Messed up a bit and got the bot MR first, had to revert and rebase.
-
Berdir →
committed d2a303e3 on 8.x-1.x authored by
Project Update Bot →
Issue #3434183 by Project Update Bot, Berdir: Automated Drupal 11...
-
Berdir →
committed d2a303e3 on 8.x-1.x authored by
Project Update Bot →
- @berdir opened merge request.
- First commit to issue fork.
- 🇨🇭Switzerland Berdir Switzerland
I was a bit concerned about the hal related test fails I saw locally, but it's caused by hal, not default_content and it's fixed by ✨ compatible with Drupal 11 Needs review
-
Berdir →
committed 542125cb on 2.0.x authored by
deepakkm →
Issue #3428127 by deepakkm, ankitv18, Berdir: Automated Drupal 11...
-
Berdir →
committed 542125cb on 2.0.x authored by
deepakkm →
- last update
4 days ago 14 pass - last update
4 days ago 14 pass Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- @manikandan-era opened merge request.
- 🇮🇳India Manikandan Era
Manikandan Era → made their first commit to this issue’s fork.
- 🇮🇳India ankitv18
PHPunit next major fatal error i.e
Fatal error: Declaration of Drupal\facets\Entity\Facet::__sleep() must be compatible with Drupal\Core\Config\Entity\ConfigEntityBase::__sleep(): array in /builds/issue/facets_pretty_paths-3430412/web/modules/contrib/facets/src/Entity/Facet.php on line 1213 /builds/issue/facets_pretty_paths-3430412/vendor/bin/phpunit:122
Is fixed in the https://git.drupalcode.org/project/facets/-/merge_requests/217/diffs#08e...
Rest all the pipelines are passing, hence marking this one as RTBC.
- @naveenvalecha opened merge request.
- First commit to issue fork.
- last update
4 days ago 62 pass - last update
4 days ago 40 pass, 44 fail - 🇺🇸United States DamienMcKenna NH, USA
Thank you for working on that. Please just replace the watchdog_exception() call entirely, it isn't needed. And I would prefer to leave in the drupal/core dependency in the composer.json file. Other than that, it's perfect.
- last update
4 days ago 14 pass - last update
4 days ago 14 pass - 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- last update
4 days ago 62 pass - @ankitv18 opened merge request.
- 🇮🇳India ankitv18
Sure I'll do that~~ waiting for the gitlab template to be merged in 2.0.x and 3.0.x dev branch
cc: @DamienMcKenna - 🇺🇸United States DamienMcKenna NH, USA
Similar to 📌 Automated Drupal 11 compatibility fixes for schema_metatag Needs work , the correct solution to replacing watchdog_exception() would be to replace it with a logger call, per https://www.drupal.org/node/2270941 → .
- 🇺🇸United States DamienMcKenna NH, USA
I don't like this as it drops support for Drupal 9.
The best approach to remove watchdog_exception() would be to replace it with a logger call, per https://www.drupal.org/node/2270941 → .
- last update
4 days ago 119 pass, 2 fail - Open on Drupal.org →Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7last update
4 days ago Not currently mergeable. - @ankitv18 opened merge request.
- 🇮🇳India Rajeshreeputra Pune
Changes looks good, although this depends on 📌 Automated Drupal 11 compatibility fixes for facets Needs work .
- 🇮🇳India heykarthikwithu Bengaluru 🌍
Released this issue in latest version 2.0.5 →
- 🇮🇳India heykarthikwithu Bengaluru 🌍
Fixed this issue in https://www.drupal.org/project/imagefield_slideshow/issues/3449695#comme... 🐛 Images not showing up at first. After page refresh they appear Fixed
Checked the feature in Drupal 11.x & Added support to 11.x
Will be released on the next release.
-
heykarthikwithu →
committed 85674bc8 on 2.0.x
Issue #3431029 by heykarthikwithu: Automated Drupal 11 compatibility...
-
heykarthikwithu →
committed 85674bc8 on 2.0.x
- last update
4 days ago 7 pass - last update
5 days ago Composer require failure - 🇮🇳India deepakkm
deepakkm → changed the visibility of the branch project-update-bot-only to hidden.
- last update
5 days ago 7 pass - last update
6 days ago 7 pass - @deepakkm opened merge request.
- 🇮🇳India ankitv18
Considering @jcnventura point at #24 of Drush 13 support, It be would be done in separate issue i.e https://www.drupal.org/project/feeds/issues/3453031 📌 Support Drush 12 and above only Active (already linked to this issue) and for log exception to support BC I've used method_exists and logException method is introduced in D10.1.
cc: @MegaChriz
- last update
6 days ago Composer require failure - last update
6 days ago 537 pass - 🇨🇭Switzerland Berdir Switzerland
lenient can't solve the conflict that devel currently has: https://gitlab.com/drupalspoons/devel/-/issues/527, temporarily removed from require-dev.
also made all submodules compatible and fixed an invalid namespace.
We have actual test fails now to work with.
- last update
6 days ago 536 pass - last update
6 days ago 536 pass - last update
6 days ago 536 pass - last update
6 days ago 536 pass - last update
6 days ago 536 pass - 🇨🇭Switzerland Berdir Switzerland
Added lenient, also pushed to separate branch to not work on top of the bot branch.
- last update
6 days ago 536 pass - @berdir opened merge request.
- 🇮🇳India ankitv18
@bbrala PHPunit next major pipeline: https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1830197
Do we need to fix this in this issue or open a separate issue? - 🇮🇳India ankitv18
@bbrala as we are supporting D10.1 and D11 then I dropped deprecation helper method as updated the code with Error::logException, also updated the gitlab template to run on previous_minor and next_minor.
for below code in response of #5
public function normalize($object, $format = NULL, array $context = []): array|bool|string|int|float|null|\ArrayObject
I believe drupal core jsonapi normalize method and other methods have these return typesPlease review the MR!52.
- last update
7 days ago 20 pass - First commit to issue fork.