Remove $update_url param from \Drupal\Tests\UpdatePathTestTrait::runUpdates

Created on 9 November 2025, 3 days ago

Problem/Motivation

Follow up to 🐛 Fix more incorrect phpdoc type hints (part 3) Active

Per @quietone:

The only instance of using the URL object is in a test, \Drupal\Tests\system\Functional\UpdateSystem\UpdatePathWithBrokenRoutingTest::testWithBrokenRouting. The test changed from using runUpdates() with no parameters to passing a URL object. Curiously, in the same issue, #3063912: Move UpdatePathTestBase::runUpdates() to a trait , the similar test core/modules/system/tests/src/Functional/Update/UpdatePathWithBrokenRoutingFilledTest.php continued to test runUpdates() with no parameters. That test is no longer in core. So, before that issue we were testing the NULL case, and now we are not. And our update tests actually do not use a parameter.

I just wonder if we should not make this change and make an issue to change testWithBrokenRouting() back to testing runUpdates() with no parameters?

Steps to reproduce

Proposed resolution

  • Remove $update_url param from runUpdates()
  • Change testWithBrokenRouting() back to testing runUpdates() with no parameters

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

database update system

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024