- Issue created by @quietone
- πΊπΈUnited States smustgrave
Seems straight forward.
Would be nice to be able to add the typehints to the actual variables but know that's a whole other mountain.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
A few things look off in the current MR, thanks folks
- π³πΏNew Zealand quietone
@larowlan, thanks for the review. I did miss quite a few changes.
These changes should made the fixes for all the comments in the MR.
- π³πΏNew Zealand quietone
Adding the type hints caused failures in 2 of the 3 files where they were added. I am removing them from those two files, core/modules/migrate/tests/src/Unit/process/FormatDateTest.php and core/tests/Drupal/Tests/Component/Render/PlainTextOutputTest.php.
- πΊπΈUnited States smustgrave
Believe feedback has been addressed. Resolved the threads except 1, didn't know if we wanted to bad typehints assertCacheRemoved or if that would be out of scope. I'm leaning to out of scope but didn't want ot make the call.
-
larowlan β
committed 7a8cfc7a on 11.x
Issue #3478185 by quietone, larowlan: Fix MissingParamType for tests
-
larowlan β
committed 7a8cfc7a on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x - thanks!
-
larowlan β
committed 38e34374 on 11.1.x
Issue #3478185 by quietone, larowlan: Fix MissingParamType for tests (...
-
larowlan β
committed 38e34374 on 11.1.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I backported this to 11.1.x
Automatically closed - issue fixed for 2 weeks with no activity.