[1.0.x] Layout Builder Anchor Navigation

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.

This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.

Have you made any other contributions that we could instead review?

I have worked on a bunch of other modules:

[1.0.x] https://www.drupal.org/project/lb_anchor_nav →
[1.0.x] https://www.drupal.org/project/pager_infinite_scroll →

There is also https://github.com/bibliophileaxe/jwt_firebase_auth_consumer/tree/1.0.x but is not in a working state and is under development.

1. Replace README.txt with README.md

https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

2. Fix PHPCS issues. You can use the PHPCS tool for checking and resolving issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml lb_anchor_nav/

FILE: lb_anchor_nav/lb_anchor_nav.module
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------


FILE: lb_anchor_nav/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 153 characters
 7 | WARNING | Line exceeds 80 characters; contains 91 characters
 8 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------

3. FILE: lb_anchor_nav.info.yml

core: 8.x
core_version_requirement: ^8 || ^9

Since Drupal 8 is now not supported, the core requirements should be changed.

These issues have been fixed. Although, I'm a little unsure why we would want to drop Drupal 8 from core version requirements. The module is usable with Drupal 8 (whether it's supported or not) and people should be able to use it that way if they so choose.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.